Page MenuHomePhabricator
Differential D3704

[web] Create `ColorSelectorButton`s in `ColorSelector` iteratively to reduce repetition
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 3:05 PM
Unknown Object (File)
Mon, Nov 11, 1:35 AM
Unknown Object (File)
Fri, Nov 8, 10:42 PM
Unknown Object (File)
Fri, Nov 8, 10:42 PM
Unknown Object (File)
Tue, Nov 5, 8:44 PM
Unknown Object (File)
Oct 16 2024, 11:26 PM
Unknown Object (File)
Oct 14 2024, 1:17 AM
Unknown Object (File)
Oct 14 2024, 1:17 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
• jacek
Commits
rCOMM61c560541fda: [web] Create `ColorSelectorButton`s in `ColorSelector` iteratively to reduce…
Summary

Instead of copy/pasting this 10 times, we can easily create ColorSelectorButtons iteratively thanks to the flex-wrap layout.

Depends on D3703

Test Plan

Things continue to look/behave as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 11 2022, 1:44 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 1:44 PM
atul edited the test plan for this revision. (Show Details)Apr 11 2022, 1:46 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 11 2022, 1:51 PM
Harbormaster failed remote builds in B8096: Diff 11323!
Harbormaster completed remote builds in B8096: Diff 11323.Apr 11 2022, 1:56 PM
atul requested review of this revision.Apr 11 2022, 1:56 PM
atul edited the summary of this revision. (Show Details)Apr 11 2022, 2:59 PM
atul added a parent revision: D3703: [web] Use `flex-wrap` to lay out `ColorSelectorButton`s in `ColorSelector`.
tomek accepted this revision.Apr 12 2022, 3:39 AM

Do we have a plan for threads that have legacy colors (arbitrary)?

This revision is now accepted and ready to land.Apr 12 2022, 3:39 AM
atul added a comment.EditedApr 12 2022, 12:02 PM

Do we have a plan for threads that have legacy colors (arbitrary)?

Yeah the plan is:

  1. Redesign the existing color picker component in native
  2. Write a DB migration that "snaps" thread colors to the closest "selectedThreadColor" (probably using tinycolor)
  3. Modify code on the server to similarly "snap" thread colors to closest "selectedThreadColor" to handle users who may be on old clients (with the old color picker)
atul updated this revision to Diff 11369.Apr 12 2022, 12:05 PM

rebase before landing

Harbormaster completed remote builds in B8134: Diff 11369.Apr 12 2022, 12:10 PM
Closed by commit rCOMM61c560541fda: [web] Create `ColorSelectorButton`s in `ColorSelector` iteratively to reduce… (authored by atul). · Explain WhyApr 12 2022, 12:10 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM61c560541fda: [web] Create `ColorSelectorButton`s in `ColorSelector` iteratively to reduce….

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
66 lines

Diff 11370

View Options

web/modals/threads/color-selector.react.js

Loading...