Page MenuHomePhabricator
Differential D3751

[landing] [chore] [ENG-1010] fix import order in webpack
ClosedPublic
Actions

Authored by • benschac on Apr 15 2022, 1:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:58 PM
Unknown Object (File)
Wed, Mar 12, 10:42 PM
Unknown Object (File)
Sat, Mar 1, 7:41 PM
Unknown Object (File)
Thu, Feb 27, 3:49 PM
Unknown Object (File)
Feb 20 2025, 9:17 PM
Unknown Object (File)
Feb 5 2025, 11:37 PM
Unknown Object (File)
Feb 4 2025, 6:31 AM
Unknown Object (File)
Feb 2 2025, 7:08 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
• abosh
• jacek
Commits
rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack
Summary

there was an import order warning. fixed it.
https://linear.app/comm/issue/ENG-1010/webpack-linting-chore

Test Plan

n/a

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 15 2022, 1:46 PM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 15 2022, 1:46 PM
• benschac added a parent revision: D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config.Apr 15 2022, 1:46 PM
Harbormaster completed remote builds in B8241: Diff 11526.Apr 15 2022, 1:55 PM
• benschac requested review of this revision.Apr 15 2022, 1:55 PM
• benschac retitled this revision from [landing] [chore] fix import order in webpack to [landing] [chore] [ENG-1010] fix import order in webpack.Apr 15 2022, 1:58 PM
• benschac edited the summary of this revision. (Show Details)Apr 18 2022, 7:22 AM
• benschac added reviewers: tomek, • abosh, • jacek.
atul added a comment.Apr 18 2022, 11:00 AM

Looks good

(probably could have been combined with D3753)

atul accepted this revision.Apr 18 2022, 11:04 AM
This revision is now accepted and ready to land.Apr 18 2022, 11:04 AM
• benschac updated this revision to Diff 11560.Apr 18 2022, 12:00 PM

rebase

Harbormaster completed remote builds in B8269: Diff 11560.Apr 18 2022, 12:07 PM
Closed by commit rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack (authored by • benschac). · Explain WhyApr 18 2022, 12:18 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack.

Revision Contents
Changeset List

PathSize
landing/
5 lines

Diff 11565

View Options

landing/webpack.config.cjs

// @flow // @flow
import type { Account as OlmAccount } from '@commapp/olm';
import cluster from 'cluster'; import cluster from 'cluster';
import schedule from 'node-schedule'; import schedule from 'node-schedule';
import { backupDB } from './backups.js'; import { backupDB } from './backups.js';
import { createDailyUpdatesThread } from './daily-updates.js'; import { createDailyUpdatesThread } from './daily-updates.js';
import { updateAndReloadGeoipDB } from './update-geoip-db.js'; import { updateAndReloadGeoipDB } from './update-geoip-db.js';
import { updateIdentityReservedUsernames } from './update-identity-reserved-usernames.js'; import { updateIdentityReservedUsernames } from './update-identity-reserved-usernames.js';
import { deleteOrphanedActivity } from '../deleters/activity-deleters.js'; import { deleteOrphanedActivity } from '../deleters/activity-deleters.js';
Show All 9 Linesimport {
deleteOrphanedSessions, deleteOrphanedSessions,
deleteOldWebSessions, deleteOldWebSessions,
} from '../deleters/session-deleters.js'; } from '../deleters/session-deleters.js';
import { deleteStaleSIWENonceEntries } from '../deleters/siwe-nonce-deleters.js'; import { deleteStaleSIWENonceEntries } from '../deleters/siwe-nonce-deleters.js';
import { deleteInaccessibleThreads } from '../deleters/thread-deleters.js'; import { deleteInaccessibleThreads } from '../deleters/thread-deleters.js';
import { deleteExpiredUpdates } from '../deleters/update-deleters.js'; import { deleteExpiredUpdates } from '../deleters/update-deleters.js';
import { deleteUnassignedUploads } from '../deleters/upload-deleters.js'; import { deleteUnassignedUploads } from '../deleters/upload-deleters.js';
import { fetchCallUpdateOlmAccount } from '../updaters/olm-account-updater.js'; import { fetchCallUpdateOlmAccount } from '../updaters/olm-account-updater.js';
import { validateAccountPrekey } from '../utils/olm-utils.js'; import { revalidateAccountPrekeys } from '../utils/olm-utils.js';
if (cluster.isMaster) { if (cluster.isMaster) {
schedule.scheduleJob( schedule.scheduleJob(
'30 3 * * *', // every day at 3:30 AM in the keyserver's timezone '30 3 * * *', // every day at 3:30 AM in the keyserver's timezone
async () => { async () => {
try { try {
// Do everything one at a time to reduce load since we're in no hurry, // Do everything one at a time to reduce load since we're in no hurry,
// and since some queries depend on previous ones. // and since some queries depend on previous ones.
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines async () => {
); );
} }
}, },
); );
schedule.scheduleJob( schedule.scheduleJob(
'0 0 * * *', // every day at midnight in the keyserver's timezone '0 0 * * *', // every day at midnight in the keyserver's timezone
async () => { async () => {
try { try {
await fetchCallUpdateOlmAccount('content', validateAccountPrekey); await fetchCallUpdateOlmAccount(
await fetchCallUpdateOlmAccount('notifications', validateAccountPrekey); 'content',
(contentAccount: OlmAccount) =>
fetchCallUpdateOlmAccount(
'notifications',
(notifAccount: OlmAccount) =>
revalidateAccountPrekeys(contentAccount, notifAccount),
),
);
} catch (e) { } catch (e) {
console.warn('encountered error while trying to validate prekeys', e); console.warn('encountered error while trying to validate prekeys', e);
} }
}, },
); );
} }