Page MenuHomePhabricator
Differential D3750

[landing] [chore] [ENG-1010] add disable comments in webpack config
AbandonedPublic
Actions

Authored by • benschac on Apr 15 2022, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 5:02 PM
Unknown Object (File)
Thu, Jan 30, 8:57 AM
Unknown Object (File)
Sun, Jan 19, 8:23 PM
Unknown Object (File)
Jan 6 2025, 6:25 PM
Unknown Object (File)
Dec 31 2024, 9:17 AM
Unknown Object (File)
Dec 29 2024, 8:23 PM
Unknown Object (File)
Nov 30 2024, 1:02 PM
Unknown Object (File)
Nov 30 2024, 9:14 AM
View All 84 Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
• jacek
• abosh
Summary

Currently, if you're using vscode and want to edit this file you'll see red swiggles everywhere. we should disable flow here if were not checking it.

https://linear.app/comm/issue/ENG-1010/webpack-linting-chore

Test Plan

everything still works as expected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Apr 15 2022, 1:45 PM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 15 2022, 1:45 PM
• benschac added a child revision: D3751: [landing] [chore] [ENG-1010] fix import order in webpack.Apr 15 2022, 1:46 PM
Harbormaster completed remote builds in B8240: Diff 11525.Apr 15 2022, 1:50 PM
• benschac requested review of this revision.Apr 15 2022, 1:50 PM
• benschac retitled this revision from [landing] [chore] add disable comments in webpack config to [landing] [chore] [ENG-1010] add disable comments in webpack config.Apr 15 2022, 1:58 PM
• benschac added reviewers: tomek, • jacek, • abosh.Apr 18 2022, 7:21 AM
• benschac edited the summary of this revision. (Show Details)
atul added a comment.Apr 18 2022, 11:02 AM

Is there a way we can modify the ESLint config to handle this instead of adding these eslint-disable comments?

atul accepted this revision.Apr 18 2022, 11:02 AM
This revision is now accepted and ready to land.Apr 18 2022, 11:02 AM
• benschac abandoned this revision.Apr 18 2022, 12:04 PM

Per @atul's comment, we can ignore entire files from the config, which is done in this diff: https://phabricator.ashoat.com/D3761

closing this diff in favor of 3761

Revision Contents
Changeset List

PathSize
landing/
2 lines

Diff 11525

View Options

landing/webpack.config.cjs

Loading...