Page MenuHomePhabricator
Differential D3791

[keyserver] [chore] [ENG-1025] remove old landing images
ClosedPublic
Actions

Authored by • benschac on Apr 20 2022, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 4:31 PM
Unknown Object (File)
Sat, Nov 16, 4:31 PM
Unknown Object (File)
Mon, Nov 11, 6:53 AM
Unknown Object (File)
Mon, Nov 11, 6:53 AM
Unknown Object (File)
Sun, Nov 10, 12:39 AM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Wed, Nov 6, 2:52 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
atul
tomek
• jacek
• abosh
Commits
rCOMMa98819d819d4: [keyserver] [chore] [ENG-1025] remove old landing images
Summary

remove svg's that are no longer in use on landing. The images are now hosted on aws. https://linear.app/comm/issue/ENG-1025/remove-old-images-from-keyserver-for-landing-page

Test Plan

run landing. All images still load as expected.

Diff Detail

Repository
rCOMM Comm
Branch
cleanup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Apr 20 2022, 12:21 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptApr 20 2022, 12:21 PM
Harbormaster completed remote builds in B8358: Diff 11669.Apr 20 2022, 12:26 PM
• benschac requested review of this revision.Apr 20 2022, 12:26 PM
atul accepted this revision.Apr 20 2022, 12:41 PM

Looks like corner_arrow is the only asset that's still being used in the codebase, and that's being pulled from AWS.

It looks like the other three assets aren't hosted on AWS, but they're also no longer used... so they should be safe to delete.

As an aside, even though these assets are preserved in the git history--it'd probably be good to have a Dropbox or Google Drive or whatever to hold onto them for archival purposes/in case they happen to be relevant in the future. (cc @ashoat)

This revision is now accepted and ready to land.Apr 20 2022, 12:41 PM
• benschac added a comment.Apr 20 2022, 1:08 PM

https://linear.app/comm/issue/ENG-1026/follow-up-if-we-want-to-store-images-somewhere-for-backup

Closed by commit rCOMMa98819d819d4: [keyserver] [chore] [ENG-1025] remove old landing images (authored by • benschac). · Explain WhyApr 20 2022, 1:09 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMa98819d819d4: [keyserver] [chore] [ENG-1025] remove old landing images.

Revision Contents
Changeset List

Diff 11669

View Options

keyserver/images/corner_arrow.svg

Loading...
View Options

keyserver/images/hero_illustration.svg

Loading...
View Options

keyserver/images/server_illustration.svg

Loading...
View Options

keyserver/images/server_illustration_small.svg

Loading...