Page MenuHomePhabricator

[keyserver] Bump `geoip-lite` to `1.4.5`
ClosedPublic

Authored by atul on Apr 27 2022, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 9:00 AM
Unknown Object (File)
Sun, Nov 24, 5:59 AM
Unknown Object (File)
Sun, Nov 24, 5:47 AM
Unknown Object (File)
Sun, Nov 24, 5:42 AM
Unknown Object (File)
Sun, Nov 24, 4:30 AM
Unknown Object (File)
Sun, Nov 24, 2:27 AM
Unknown Object (File)
Wed, Nov 13, 10:44 AM
Unknown Object (File)
Tue, Nov 5, 4:35 AM

Details

Summary

Downstream dependencies have issues surfaced by yarn audit

The repo doesn't have release notes, but skimmed through commits since 1.4.0 and there don't seem to be any breaking changes.


Depends on D3859

Test Plan

CI

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

(As of this diff, we've gone from 73 to 50 vulnerabilities according to yarn audit)

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 27 2022, 8:35 AM
Harbormaster failed remote builds in B8609: Diff 11993!
atul requested review of this revision.Apr 27 2022, 9:18 AM

Can you also test wherever we use geoip-lite to make sure it still works as expected? You can do this with cd keyserver && yarn update-geoip, but you'll need to create a keyserver/secrets/geoip_license.json file first.

comm@server:/var/www/comm$ cat keyserver/secrets/geoip_license.json
{
  "key": "SECRET_KEY_HERE_GET_THIS_FROM_ONE_PASSWORD"
}
This revision is now accepted and ready to land.Apr 27 2022, 2:40 PM

Can you also test wherever we use geoip-lite to make sure it still works as expected? You can do this with cd keyserver && yarn update-geoip, but you'll need to create a keyserver/secrets/geoip_license.json file first.

comm@server:/var/www/comm$ cat keyserver/secrets/geoip_license.json
{
  "key": "SECRET_KEY_HERE_GET_THIS_FROM_ONE_PASSWORD"
}

Yeah I'll give that a go. Thanks for the clear instructions, I don't have any context on geoip-lite.

Don't have access to 1Password at the moment (don't have work machine), but will test and land once I'm back.

Can you also test wherever we use geoip-lite to make sure it still works as expected? You can do this with cd keyserver && yarn update-geoip, but you'll need to create a keyserver/secrets/geoip_license.json file first.

comm@server:/var/www/comm$ cat keyserver/secrets/geoip_license.json
{
  "key": "SECRET_KEY_HERE_GET_THIS_FROM_ONE_PASSWORD"
}

Getting the following, it's not exiting and there's no indication it succeeded:

0f7a.png (572×1 px, 155 KB)


edit: added some logging in update-geo-db.js and node_modules/geo-ip/scripts/updatedb.js to try to diagnose... but by time I got back to terminal it looks like it completed. took like 120 seconds which was longer than I'd expect w/o context

rebase before landing (after testing)

This revision was automatically updated to reflect the committed changes.