Page MenuHomePhabricator

[web] Use callback version of set state for `setQueuedChanges`
ClosedPublic

Authored by atul on May 2 2022, 12:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 4:56 AM
Unknown Object (File)
Tue, Nov 5, 4:56 AM
Unknown Object (File)
Tue, Nov 5, 4:56 AM
Unknown Object (File)
Tue, Nov 5, 4:56 AM
Unknown Object (File)
Thu, Oct 10, 2:28 AM
Unknown Object (File)
Sep 23 2024, 1:17 PM
Unknown Object (File)
Sep 23 2024, 1:17 PM
Unknown Object (File)
Sep 23 2024, 1:17 PM

Details

Summary

Addresses feedback from @palys-swm here: https://phabricator.ashoat.com/D3827?id=11833#inline-23376

Unfortunately couldn't name the argument queuedChanges because that's already defined in the scope and led to eslint warnings, so had to go with prevQueuedChanges which I'm not a huge fan of and imo makes things a bit less readable.

Test Plan
  1. Open ThreadSettingsModal
  2. Make some changes (name, description, color)
  3. Log the "queued changes"
  4. Hit save
  5. Ensure that the "queued changes" are made as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable