Page MenuHomePhabricator
Differential D3890

[web] Use callback version of set state for `setQueuedChanges`
ClosedPublic
Actions

Authored by atul on May 2 2022, 12:18 PM.
Tags
None
Referenced Files
F5096066: D3890.diff
Sun, Mar 30, 7:58 PM
Unknown Object (File)
Sun, Mar 30, 12:08 PM
Unknown Object (File)
Thu, Mar 27, 2:12 AM
Unknown Object (File)
Fri, Mar 7, 6:48 AM
Unknown Object (File)
Mon, Mar 3, 5:34 PM
Unknown Object (File)
Feb 26 2025, 9:44 PM
Unknown Object (File)
Feb 14 2025, 10:05 PM
Unknown Object (File)
Feb 2 2025, 3:39 PM
View All Files
Subscribers
• abosh
• adrian
• karol
tomek

Details

Reviewers
• jacek
tomek
ashoat
• benschac
Commits
rCOMMbe73d28d5b78: [web] Use callback version of set state for `setQueuedChanges`
Summary

Addresses feedback from @palys-swm here: https://phabricator.ashoat.com/D3827?id=11833#inline-23376

Unfortunately couldn't name the argument queuedChanges because that's already defined in the scope and led to eslint warnings, so had to go with prevQueuedChanges which I'm not a huge fan of and imo makes things a bit less readable.

Test Plan
  1. Open ThreadSettingsModal
  2. Make some changes (name, description, color)
  3. Log the "queued changes"
  4. Hit save
  5. Ensure that the "queued changes" are made as expected

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 12149

View Options

web/modals/threads/thread-settings-general-tab.react.js

#include "CommQueryExecutor.h" #include "CommQueryExecutor.h"
#include "Logger.h"
#include "sqlite_orm.h" #include "sqlite_orm.h"
#include <sqlite3.h> #include <sqlite3.h>
#include <cstdio> #include <cstdio>
#include <iostream> #include <iostream>
#include <string> #include <string>
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
#include <emscripten/bind.h> #include <emscripten/bind.h>
#endif #endif
namespace comm { namespace comm {
using namespace sqlite_orm; using namespace sqlite_orm;
std::string DB_PATH = "test.sqlite"; std::string DB_PATH = "test.sqlite";
struct Test { struct Test {
std::string id; std::string id;
std::string data; std::string data;
}; };
std::string CommQueryExecutor::testDBOperation() { std::string CommQueryExecutor::testDBOperation() {
Logger::log("Beginning test db operation!");
sqlite3 *db; sqlite3 *db;
sqlite3_open(DB_PATH.c_str(), &db); sqlite3_open(DB_PATH.c_str(), &db);
std::string createTableQuery = std::string createTableQuery =
"CREATE TABLE IF NOT EXISTS test (" "CREATE TABLE IF NOT EXISTS test ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL," " id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");"; ");";
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines
View Options

web/modals/threads/thread-settings-privacy-tab.react.js

#include "CommQueryExecutor.h" #include "CommQueryExecutor.h"
#include "Logger.h"
#include "sqlite_orm.h" #include "sqlite_orm.h"
#include <sqlite3.h> #include <sqlite3.h>
#include <cstdio> #include <cstdio>
#include <iostream> #include <iostream>
#include <string> #include <string>
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
#include <emscripten/bind.h> #include <emscripten/bind.h>
#endif #endif
namespace comm { namespace comm {
using namespace sqlite_orm; using namespace sqlite_orm;
std::string DB_PATH = "test.sqlite"; std::string DB_PATH = "test.sqlite";
struct Test { struct Test {
std::string id; std::string id;
std::string data; std::string data;
}; };
std::string CommQueryExecutor::testDBOperation() { std::string CommQueryExecutor::testDBOperation() {
Logger::log("Beginning test db operation!");
sqlite3 *db; sqlite3 *db;
sqlite3_open(DB_PATH.c_str(), &db); sqlite3_open(DB_PATH.c_str(), &db);
std::string createTableQuery = std::string createTableQuery =
"CREATE TABLE IF NOT EXISTS test (" "CREATE TABLE IF NOT EXISTS test ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL," " id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");"; ");";
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines