Page MenuHomePhabricator
Differential D3944

[web] Add check and notifications settings icons
ClosedPublic
Actions

Authored by • jacek on May 6 2022, 7:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:25 PM
Unknown Object (File)
Sat, Nov 9, 11:40 PM
Unknown Object (File)
Sat, Nov 9, 5:55 PM
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Sat, Nov 9, 4:03 PM
Unknown Object (File)
Sat, Nov 9, 3:14 PM
Unknown Object (File)
Fri, Nov 8, 12:47 PM
Unknown Object (File)
Fri, Nov 8, 12:47 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
• benschac
tomek
atul
Commits
rCOMM184faca8b641: [web] Add check and notifications settings icons
Summary

Imported with IcoMoon new icons used in notification settings. Three of them are custom SVGs from Figma for different settings, and one is check icon from SWM Icon Pack

Screenshot_Google Chrome_2022-05-06_161622.png (257×1 px, 13 KB)

Test Plan

Confirm, that all existing icons display correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.May 6 2022, 7:14 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 6 2022, 7:14 AM
• jacek edited the summary of this revision. (Show Details)May 6 2022, 7:17 AM
• jacek added a reviewer: • benschac.
• jacek added reviewers: tomek, atul.
Harbormaster completed remote builds in B8855: Diff 12351.May 6 2022, 7:19 AM
• jacek requested review of this revision.May 6 2022, 7:19 AM
atul accepted this revision.May 6 2022, 7:52 AM

Nice!

This revision is now accepted and ready to land.May 6 2022, 7:52 AM
• jacek added a child revision: D3947: [web] Introduce `NotificationsOptionInfo` component.May 6 2022, 8:09 AM
• jacek added a child revision: D3953: [web] Introduce thread notification settings options in modal.
tomek accepted this revision.May 9 2022, 8:26 AM
• jacek updated this revision to Diff 12604.May 13 2022, 1:58 AM

rebase

Harbormaster completed remote builds in B9058: Diff 12604.May 13 2022, 2:02 AM
Closed by commit rCOMM184faca8b641: [web] Add check and notifications settings icons (authored by • jacek). · Explain WhyMay 13 2022, 3:36 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM184faca8b641: [web] Add check and notifications settings icons.

Revision Contents
Changeset List

PathSize
web/
6 lines
icons/
538 lines
558 lines

Diff 12604

View Options

web/SWMansionIcon.react.js

Loading...
View Options

web/icons/AppIcons.json

Loading...
View Options

web/icons/selection.json

Loading...