Page MenuHomePhabricator
Differential D3984

Implement translation of raw string from notification into SQLite database entities.
ClosedPublic
Actions

Authored by marcin on May 10 2022, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 5:06 AM
Unknown Object (File)
Fri, Nov 8, 4:51 AM
Unknown Object (File)
Thu, Nov 7, 6:39 AM
Unknown Object (File)
Sat, Nov 2, 10:50 AM
Unknown Object (File)
Sun, Oct 20, 7:38 PM
Unknown Object (File)
Sun, Oct 20, 6:39 PM
Unknown Object (File)
Oct 7 2024, 7:45 PM
Unknown Object (File)
Oct 7 2024, 7:45 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• karol
Commits
rCOMMaac27df40116: Implement translation of raw string from notification into SQLite database…
Summary

This diff uses functions implemented in ptwo previous diffs to convert raw string into SQlite database entities

Test Plan

No testing plan. Future diffs will provide a code that uses those functions on iOS and Android respectively

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.May 10 2022, 2:53 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 2:53 AM
marcin added a parent revision: D3983: Implement translation of message JSON object into SQLite database entities.May 10 2022, 2:57 AM
marcin updated this revision to Diff 12487.May 10 2022, 3:05 AM

Update commit message to include diff link

Harbormaster completed remote builds in B8971: Diff 12481.May 10 2022, 3:09 AM
Harbormaster completed remote builds in B8977: Diff 12487.May 10 2022, 3:40 AM
marcin requested review of this revision.May 10 2022, 3:40 AM
marcin added a child revision: D3986: Implement function to store SQLite database entities from raw notification string in SQLite database.May 10 2022, 4:35 AM
• karol accepted this revision.May 10 2022, 6:22 AM
• karol added 1 blocking reviewer(s): tomek.

LGTM, I think it would be good if Tomek took a loook.

tomek requested changes to this revision.May 11 2022, 4:49 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/MessageOperationsUtilities/MessageOperationsUtilities.cpp
87–92

In this case if any message is malformed, we stop saving all the messages from an array. What do you think about doing the opposite: even if there are malformed messages, save all the well-formed into the db?

This revision now requires changes to proceed.May 11 2022, 4:49 AM
marcin updated this revision to Diff 12540.May 11 2022, 6:58 AM

Implement error handling

Harbormaster failed remote builds in B9002: Diff 12540!May 11 2022, 6:59 AM
marcin updated this revision to Diff 12553.May 11 2022, 8:13 AM

Retrigger CI

Harbormaster completed remote builds in B9015: Diff 12553.May 11 2022, 8:58 AM
Harbormaster completed remote builds in B9002: Diff 12540.May 11 2022, 9:46 AM
tomek accepted this revision.May 12 2022, 1:45 AM
This revision is now accepted and ready to land.May 12 2022, 1:45 AM
marcin updated this revision to Diff 12716.May 16 2022, 4:56 AM

Pass string by reference

Harbormaster failed remote builds in B9139: Diff 12716!May 16 2022, 4:56 AM
marcin updated this revision to Diff 12728.May 16 2022, 5:14 AM

Rebase

Harbormaster failed remote builds in B9151: Diff 12728!May 16 2022, 5:15 AM
Harbormaster completed remote builds in B9151: Diff 12728.May 16 2022, 1:22 PM
marcin updated this revision to Diff 12799.May 17 2022, 2:54 AM

Rebase

Harbormaster failed remote builds in B9208: Diff 12799!May 17 2022, 2:55 AM
Harbormaster completed remote builds in B9208: Diff 12799.May 17 2022, 5:59 AM
marcin updated this revision to Diff 12847.May 18 2022, 2:09 AM

Rebase

Harbormaster failed remote builds in B9251: Diff 12847!May 18 2022, 2:10 AM
Harbormaster completed remote builds in B9251: Diff 12847.May 18 2022, 2:35 AM
marcin updated this revision to Diff 12865.May 18 2022, 4:08 AM

Rebase

Harbormaster failed remote builds in B9268: Diff 12865!May 18 2022, 4:09 AM
marcin updated this revision to Diff 12880.May 18 2022, 4:54 AM

Rebase

Harbormaster failed remote builds in B9280: Diff 12880!May 18 2022, 4:54 AM
Harbormaster completed remote builds in B9280: Diff 12880.May 18 2022, 5:52 AM
Harbormaster completed remote builds in B9268: Diff 12865.May 18 2022, 7:28 AM
marcin updated this revision to Diff 13001.May 23 2022, 5:40 AM

Use prulal form for rawMessageInfosString

Harbormaster completed remote builds in B9383: Diff 13001.May 23 2022, 5:46 AM
marcin updated this revision to Diff 13031.May 24 2022, 12:42 AM

Rebase master

Harbormaster completed remote builds in B9411: Diff 13031.May 24 2022, 1:10 AM
marcin updated this revision to Diff 13941.Jun 29 2022, 3:35 AM

Rebase and move to persistent storage utilities

Harbormaster completed remote builds in B10087: Diff 13941.Jun 29 2022, 4:14 AM
marcin updated this revision to Diff 13947.Jun 29 2022, 4:36 AM

Rebase

Harbormaster failed remote builds in B10093: Diff 13947!Jun 29 2022, 4:51 AM
Harbormaster completed remote builds in B10093: Diff 13947.Jun 29 2022, 5:21 AM
Closed by commit rCOMMaac27df40116: Implement translation of raw string from notification into SQLite database… (authored by marcin). · Explain WhyJun 29 2022, 5:22 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMaac27df40116: Implement translation of raw string from notification into SQLite database….

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
MessageOperationsUtilities/
21 lines

Diff 12487

View Options

native/cpp/CommonCpp/NativeModules/MessageOperationsUtilities/MessageOperationsUtilities.cpp

Loading...