Page MenuHomePhabricator
Differential D3994

[docs] Remove Herald rule section from docs
ClosedPublic
Actions

Authored by ashoat on May 10 2022, 6:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:44 AM
Unknown Object (File)
Tue, Nov 19, 5:00 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Fri, Nov 8, 8:09 PM
Unknown Object (File)
Fri, Nov 8, 8:06 AM
Unknown Object (File)
Tue, Nov 5, 2:00 AM
Unknown Object (File)
Oct 15 2024, 10:57 AM
View All Files
Subscribers
• abosh
• adrian
tomek

Details

Reviewers
• benschac
atul
Commits
rCOMM2df4139912fb: [docs] Remove Herald rule section from docs
Summary

The team has grown large enough now that this Herald rule is too noisy. This closes ENG-1055.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 10 2022, 6:06 AM
Herald added subscribers: • abosh, • adrian, tomek. · View Herald TranscriptMay 10 2022, 6:06 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 10 2022, 6:11 AM
Harbormaster failed remote builds in B8987: Diff 12503!
ashoat requested review of this revision.May 10 2022, 6:24 AM

Android failed once, but there's no chance this docs diff is causing an Android build failure

Harbormaster completed remote builds in B8987: Diff 12503.May 10 2022, 6:26 AM
atul accepted this revision.May 10 2022, 6:40 AM

It might be good to put this somewhere in the Notion docs so we can point new devs to it as a "template?"

This revision is now accepted and ready to land.May 10 2022, 6:40 AM
atul added a comment.May 10 2022, 6:59 AM
In D3994#111819, @ashoat wrote:

Android failed once, but there's no chance this docs diff is causing an Android build failure

Ah yeah sorry, continuing to run into intermittent issues with the ci-beaver machine. Going to create a replacement Android CI machine via AWS EC2 and hope that works without issue.

ashoat added a comment.May 10 2022, 7:37 AM
In D3994#111864, @atul wrote:

It might be good to put this somewhere in the Notion docs so we can point new devs to it as a "template?"

Okay, I copy-pasted it here

Closed by commit rCOMM2df4139912fb: [docs] Remove Herald rule section from docs (authored by ashoat). · Explain WhyMay 10 2022, 7:40 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM2df4139912fb: [docs] Remove Herald rule section from docs.

Revision Contents
Changeset List

PathSize
docs/
11 lines

Diff 12519

View Options

docs/dev_environment.md

Loading...