Page MenuHomePhabricator
Differential D4009

[web] Introduce a callback that should be called after menu visibility is changed
ClosedPublic
Actions

Authored by tomek on May 11 2022, 8:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 4:31 PM
Unknown Object (File)
Wed, May 15, 12:37 PM
Unknown Object (File)
Wed, May 15, 12:37 PM
Unknown Object (File)
Wed, May 15, 12:37 PM
Unknown Object (File)
Tue, May 14, 4:53 AM
Unknown Object (File)
Apr 19 2024, 7:11 PM
Unknown Object (File)
Apr 19 2024, 7:11 PM
Unknown Object (File)
Apr 19 2024, 7:11 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• benschac
atul
• jacek
Commits
rCOMM15f6334c6d04: [web] Introduce a callback that should be called after menu visibility is…
Summary

We need to call this callback when visibility change so that we can block / unblock user list scroll
Depends on D4008

Test Plan

Provide a callback that console logs its argument and check if after clicking through the menu logged value is correct

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 11 2022, 8:45 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 11 2022, 8:45 AM
tomek added a child revision: D4010: [web] Store information about menu visibility in state and block scrolling if needed.May 11 2022, 8:52 AM
Harbormaster completed remote builds in B9022: Diff 12560.May 11 2022, 10:16 AM
tomek requested review of this revision.May 11 2022, 10:16 AM
• benschac accepted this revision.May 11 2022, 10:48 AM
This revision is now accepted and ready to land.May 11 2022, 10:48 AM
tomek added 1 blocking reviewer(s): atul.May 12 2022, 8:16 AM
This revision now requires review to proceed.May 12 2022, 8:16 AM
atul accepted this revision.May 12 2022, 9:02 AM
This revision is now accepted and ready to land.May 12 2022, 9:02 AM
tomek updated this revision to Diff 12656.May 13 2022, 7:04 AM

Rebase

Harbormaster completed remote builds in B9096: Diff 12656.May 13 2022, 7:09 AM
Closed by commit rCOMM15f6334c6d04: [web] Introduce a callback that should be called after menu visibility is… (authored by tomek). · Explain WhyMay 16 2022, 4:40 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM15f6334c6d04: [web] Introduce a callback that should be called after menu visibility is….

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
15 lines
1 line

Diff 12706

View Options

web/settings/relationship/friend-list-row.react.js

Loading...
View Options

web/settings/relationship/user-list.react.js

Loading...