Page MenuHomePhabricator

[server] [fix] Unify permissions for `OPEN_SUBTHREAD` and `SECRET_SUBTHREAD`
ClosedPublic

Authored by jacek on May 18 2022, 3:34 AM.
Tags
None
Referenced Files
F3369956: D4069.diff
Tue, Nov 26, 12:23 AM
Unknown Object (File)
Fri, Nov 8, 5:27 PM
Unknown Object (File)
Fri, Nov 8, 2:05 AM
Unknown Object (File)
Mon, Nov 4, 5:36 PM
Unknown Object (File)
Mon, Nov 4, 5:36 PM
Unknown Object (File)
Mon, Nov 4, 5:36 PM
Unknown Object (File)
Mon, Nov 4, 5:36 PM
Unknown Object (File)
Sat, Nov 2, 9:49 AM

Details

Summary

Unify permissions for community OPEN and SECRET subthread to solve the issue:
https://linear.app/comm/issue/ENG-1004/error-when-adding-user-that-is-not-in-parent-thread-to-open-subchannel

The diff requires database migration to fix permissions in already existing threads. It will be introduced in follow-up diff.

Test Plan

Create new Open thread nested in Secret thread - the issue described in ENG-1004 should no longer exist.
Users not in parent thread can now be added to child thread. Tested in mobile and web app.
After database migration the issue should also disappear in all already existing threads.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage