Page MenuHomePhabricator

[services] Backup - Add Attachment Reactor Logic
ClosedPublic

Authored by karol on May 26 2022, 3:07 AM.
Tags
None
Referenced Files
F2156787: D4135.diff
Mon, Jul 1, 12:42 AM
F2154312: D4135.id13157.diff
Sun, Jun 30, 7:01 PM
F2149137: D4135.id13212.diff
Sun, Jun 30, 7:09 AM
F2149136: D4135.id13157.diff
Sun, Jun 30, 7:09 AM
F2149135: D4135.id13143.diff
Sun, Jun 30, 7:09 AM
F2149105: D4135.id.diff
Sun, Jun 30, 7:09 AM
F2149074: D4135.diff
Sun, Jun 30, 7:05 AM
Unknown Object (File)
Sat, Jun 29, 2:16 PM

Details

Summary

Depends on D4134

Adding AddAttachments logic. This is a Unary Reactor which means it goes only for one cycle, the response is empty, so it effectively just receives the data on the server and then returns a status.

logID is optional. If it's an empty string, the attachments are appended to the backup item.

Test Plan
  • terminal 1
cd services
yarn run-blob-service-dev-mode
  • terminal 2
cd services
yarn run-backup-service-dev-mode
  • terminal 3
git clone https://github.com/karol-bisztyga/grpc-playground.git
cd grpc-playground
git checkout backup-async
./build.sh
./cmake/build/bin/client
  • in terminal 3 create a new backup with n
  • check the database and see the empty string in attachmentHolders in the newly created item
  • add new attachments: in terminal 3 use b
  • check the database again and see new attachments in attachmentHolders in the newly created item
  • do a similar thing for the logs: first, use l and then k

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.
This revision is now accepted and ready to land.May 27 2022, 6:03 AM
karol edited the summary of this revision. (Show Details)
karol edited the test plan for this revision. (Show Details)

update