[keyserver] Add Webpack builds to keyserver Dockerfile
ClosedPublic
Actions

Authored by ashoat on Jun 1 2022, 1:29 AM.

Details

Reviewers

tomek
atul

Commits

rCOMM3164cc8a5d6f: [keyserver] Add Webpack builds to keyserver Dockerfile

Summary

Totally forgot about this, and didn't notice it until I actually tried to load a webpage from the Node keyserver.

I basically forgot to run keyserver/bash/setup.sh, but some of that file isn't relevant and I think it helps readability / discoverability to explicitly put these commands in the Dockerfile.

Depends on D4171

Test Plan

Make sure that the crash that was appearing regarding an assets.json import goes away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 1 2022, 1:29 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJun 1 2022, 1:29 AM

ashoat added a child revision: D4173: [keyserver] Allow listening address to be configured.Jun 1 2022, 1:30 AM

Harbormaster completed remote builds in B9567: Diff 13265.Jun 1 2022, 1:44 AM

ashoat requested review of this revision.Jun 1 2022, 1:44 AM

atul accepted this revision.Jun 1 2022, 7:26 AM

atul added inline comments.

keyserver/Dockerfile
54–55	I think we can combine these into a single "layer"? Something like: RUN yarn workspace web prod && yarn workspace landing prod Not sure that it matters or makes a difference

This revision is now accepted and ready to land.Jun 1 2022, 7:26 AM

ashoat added inline comments.Jun 1 2022, 9:48 AM

keyserver/Dockerfile
54–55	In D4175 we end up separating these I don't think there's actually any benefit in combining this lines, and in general I prefer to keep them separate for readability