Implement C++ code to update thread unread status in SQLite.
Details
Details
No tsting plan. Further diffs will use this functionality onn iOS and Android and provide appropriate testing plan.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 85–86 ↗ | (On Diff #13391) | Do we need both of these lines? Can we simply GLOB_RECURSE the COMMON_NATIVE_CODE line? Then I think we could potentially remove the GRPC_CODE line |
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 85–86 ↗ | (On Diff #13391) | We can get rid of COMMON_NATIVE_INTERNAL by replacing GLOB with GLOB_RECURSE in COMMON_NATIVE_CODE. Perhaps we could also get rid of GRPC_CODE, but I would not do so. Grpc generated files end with .cc, so we would need to pass another globbing pattern to GLOB_RECURSE. Moreover it is in separate directory on the same directory level as NativeModules, so perhaps it is more readable to keep it separately. |