localstack -> LocalStack

Fixed.

There should be an additional line break between these two paragraphs.

Fixed.

This shouldn't be on its own line

Fixed.

hmm does it really start rabbitmq?

Hmm, nice catch it starts only the localstack and initializes the terraform. I've changed this.

may not be super-clear what is what here. Maybe we could go with something like I suggested?

Why not, done.

grammarly

Fixed.

new line

Fixed.

I think this will look strange when formatted It uses LocalStack local cloud including.... Maybe we can use a different link text?

Yes, I think we should use this text.

The command is outdated D4303

Updated this diff based on the D4303 changes.

We capitalize tunnelbroker in other places

Thanks for catching it!

This is inconsistent with the description. We say that a command looks like this yarn run-[service-name]-dev-mode, and the name is tunnelbroker, so the command should be yarn run-tunnelbroker-dev-mode.

If this command is correct, we should update the description to use yarn run-[service-name]-service-dev-mode. We haven't specified what we mean by service-name, but it's fair to assume that -service is not a part of it. If we expect -service to be a part of service-name we should clearly tell it somewhere.

I've changed the command template to the yarn run-[service-name]-service-dev-mode to be consistent. Thanks!

Not sure I understand what this means

Slightly changed this sentence. Maybe now it's clearer.

"a [RabbitMQ]"

Fixed.

Why are we hyperlinking to this website twice?

It's a common practice in the docs to hyperlink all the occurrences, but I don't mind making it only once. Let's go with the only hyperlink. Changed this.

"for Tunnelbroker"

Fixed.

I don't think this sentence is necessary

Removed it.

no need to keep linking to this website

Removed the whole sentence.

1. "dev-mode" doesn't sound clean... it feels like we're using unnecessary jargon here. Why not just "dev mode"? That's how we usually refer to it in text, I think
2. It seems like we shouldn't even be calling this "dev mode".... how about just "Running services locally"?

I agree that "Running services locally" would be more informative and clearer. Changed it.

Does this make it easier, or is it basically required? Is there another supported way to run tests, for instance?

My impression is that this is the default way we're going to be using for integration tests going forward, so I think we should not frame this install as optional.

I Agree that it can be misleading. I'll change this to be required actually.

Grammarly shows an issue when we convert the sentence to such way. I think it's more natural for English to use the original sentence. Passing to @varun to check about this.

Docker should be capitalized. Please be thoughtful about capitalization... it's a waste of everybody's time when people have to repeatedly give you feedback on styling names in docs diffs

I'm sorry, missed this one. Fixed and re-checked all such occurrences.

1. I think this should be in its own section, eg. ## Running in dev mode
2. The section should start with a simple explanation of what dev mode is / what dev mode does, and why you might want to run services in dev mode

That makes sense to me. I've added the section with the complete description of this mode.

This paragraph doesn't really flow from the previous. I can commandeer this diff if this feedback isn't clear

I've slightly restructured the doc updates.
Moved this paragraph slightly upward. Maybe now it's more clear.

It's not clear to me what the difference is between "running services locally" and "running services in dev mode"

I've changed the paragraph titles and slightly restructured them. Maybe now it's clearer.