Page MenuHomePhabricator

[native] [web] Improve wording when clearing thread name or description
ClosedPublic

Authored by abosh on Jun 23 2022, 11:44 AM.
Tags
None
Referenced Files
F3630512: D4346.diff
Thu, Jan 2, 11:46 PM
Unknown Object (File)
Thu, Dec 26, 4:31 AM
Unknown Object (File)
Tue, Dec 24, 9:42 AM
Unknown Object (File)
Sun, Dec 15, 4:53 PM
Unknown Object (File)
Sun, Dec 15, 4:53 PM
Unknown Object (File)
Nov 9 2024, 7:38 PM
Unknown Object (File)
Nov 9 2024, 7:37 PM
Unknown Object (File)
Nov 9 2024, 5:23 PM

Details

Summary

Related Linear issue with full context here. Improved the wording of the robotext that is outputted when setting the thread name or description to the empty string.

Before:

image.png (406×1 px, 110 KB)

After:

image.png (502×964 px, 50 KB)

Test Plan

Looks as expected on web and native, also changed thread name and description on web and native and both platforms match/work as expected:

image.png (808×814 px, 115 KB)
image.png (736×952 px, 77 KB)

Also tested to make sure the notification text matches the updated robotext (thanks @palys-swm for your help here!):

Screen Shot 2022-06-22 at 4.45.54 PM.png (2×1 px, 2 MB)
Screen Shot 2022-06-22 at 4.41.58 PM.png (2×1 px, 2 MB)
Screen Shot 2022-06-23 at 1.03.27 PM.png (2×1 px, 2 MB)
Screen Shot 2022-06-23 at 1.03.44 PM.png (2×1 px, 2 MB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

abosh edited the test plan for this revision. (Show Details)
abosh edited the test plan for this revision. (Show Details)
tomek added a reviewer: ashoat.

Makes sense to me! Really appreciate that you checked notif text as part of the test plan.

This revision is now accepted and ready to land.Jun 28 2022, 1:19 PM