Page MenuHomePhabricator
Differential D4350

[services][identity] helper function to start PAKE login
ClosedPublic
Actions

Authored by varun on Jun 24 2022, 6:31 AM.
Tags
None
Referenced Files
F3114790: D4350.diff
Thu, Oct 31, 8:44 PM
Unknown Object (File)
Mon, Oct 21, 8:35 PM
Unknown Object (File)
Mon, Oct 21, 6:26 AM
Unknown Object (File)
Fri, Oct 18, 6:09 PM
Unknown Object (File)
Sat, Oct 12, 1:04 PM
Unknown Object (File)
Sat, Oct 12, 12:40 PM
Unknown Object (File)
Thu, Oct 10, 1:44 AM
Unknown Object (File)
Thu, Oct 10, 1:44 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• jim
• karol
Commits
rCOMM0867427da96b: [services][identity] helper function to start PAKE login
Summary

fetch registration data from database, generate challenge for user, return challenge or error

Test Plan

tested with method that calls this helper function

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 24 2022, 6:31 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 24 2022, 6:31 AM
varun added a parent revision: D4285: [services][identity] wallet login.Jun 24 2022, 6:32 AM
varun added a child revision: D4351: [services][identity] helper function to finish PAKE login.Jun 24 2022, 6:33 AM
Harbormaster completed remote builds in B9946: Diff 13757.Jun 24 2022, 6:35 AM
varun requested review of this revision.Jun 24 2022, 6:35 AM
varun added 1 blocking reviewer(s): • jim.Jun 24 2022, 8:31 AM
varun updated this revision to Diff 13816.Jun 27 2022, 1:01 AM

rebase

varun edited parent revisions, added: D4362: [services][identity] update Config struct to hold keypair instead of just private key; removed: D4285: [services][identity] wallet login.Jun 27 2022, 1:01 AM
Harbormaster completed remote builds in B9999: Diff 13816.Jun 27 2022, 1:21 AM
tomek requested changes to this revision.Jun 27 2022, 3:22 AM
tomek added inline comments.
services/identity/src/service.rs
345 ↗(On Diff #13816)

I'm not sure if it is a good practice in rust, but returning values by parameters is usually really bad for maintainability of the code. We should clearly define a contract where parameters are used to provide the input for a function, and its result is returned. So in this case, server_login should become a part of the value that is returned.

This revision now requires changes to proceed.Jun 27 2022, 3:22 AM
varun updated this revision to Diff 13842.Jun 27 2022, 8:28 AM

address feedback

services/identity/src/service.rs
345 ↗(On Diff #13816)

makes sense

Harbormaster completed remote builds in B10007: Diff 13842.Jun 27 2022, 8:34 AM
• karol accepted this revision.Jun 28 2022, 2:01 AM
tomek accepted this revision.Jun 28 2022, 4:45 AM
varun removed 1 blocking reviewer(s): • jim.Jun 28 2022, 6:22 AM
This revision is now accepted and ready to land.Jun 28 2022, 6:22 AM
Closed by commit rCOMM0867427da96b: [services][identity] helper function to start PAKE login (authored by varun). · Explain WhyJun 28 2022, 7:12 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0867427da96b: [services][identity] helper function to start PAKE login.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
6 lines
84 lines

Diff 13757

View Options

services/identity/src/config.rs

Loading...
View Options

services/identity/src/service.rs

Loading...