Page MenuHomePhabricator
Differential D4404

[docs] updated dev env docs for protobuf edge case
ClosedPublic
Actions

Authored by • derek on Jun 29 2022, 12:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 12:21 PM
Unknown Object (File)
Mon, Nov 11, 2:52 AM
Unknown Object (File)
Fri, Nov 8, 12:50 PM
Unknown Object (File)
Fri, Nov 8, 12:50 PM
Unknown Object (File)
Fri, Nov 8, 12:50 PM
Unknown Object (File)
Fri, Nov 8, 12:50 PM
Unknown Object (File)
Fri, Nov 8, 12:50 PM
Unknown Object (File)
Fri, Nov 8, 12:50 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
ashoat
varun
• abosh
atul
Commits
rCOMM037d3f89d54a: [docs] updated dev env docs for protobuf edge case
Test Plan

just tested the solution

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• derek created this revision.Jun 29 2022, 12:06 PM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 29 2022, 12:06 PM
• derek added a comment.EditedJun 29 2022, 12:10 PM

i tried to undo the spacing change on the arc diff line but it's giving me empty git error

Harbormaster completed remote builds in B10111: Diff 13976.Jun 29 2022, 12:19 PM
• derek requested review of this revision.Jun 29 2022, 12:19 PM
• derek added reviewers: ashoat, atul.Jun 29 2022, 12:28 PM
• derek added reviewers: varun, • abosh.
ashoat added inline comments.Jun 29 2022, 12:29 PM
docs/dev_environment.md
822 ↗(On Diff #13976)

You removed a space following "Differential Revision:"

ashoat requested changes to this revision.Jun 29 2022, 12:30 PM
ashoat added inline comments.
docs/dev_environment.md
323 ↗(On Diff #13976)
  1. Can we say `In the event that Homebrew installs Protobuf anyway"?
  2. Can we put the new sentence on a new paragraph? I think it will be harder to miss that way
This revision now requires changes to proceed.Jun 29 2022, 12:30 PM
atul resigned from this revision.Aug 15 2022, 9:47 AM

Resigning because docs diff.

• derek updated this revision to Diff 16007.Aug 26 2022, 9:14 AM

Updating D4404: Summary: updated dev env docs for protobuf edge case, responded to diff comments

Harbormaster failed remote builds in B11640: Diff 16007!Aug 26 2022, 9:15 AM
• derek added a comment.EditedAug 26 2022, 9:17 AM

@ashoat as per your comment I fixed the spacing on line 822 in my last commit - my guess is flow (or some other part of the precommit hook) is linting that space. i'll reach out to dev & find someone to help me troubleshoot that

• derek updated this revision to Diff 16008.Aug 26 2022, 9:33 AM

Updating D4404: fixed whitespace

Harbormaster failed remote builds in B11641: Diff 16008!Aug 26 2022, 9:33 AM
• derek updated this revision to Diff 16009.Aug 26 2022, 9:36 AM

Updating D4404: rebased

Harbormaster completed remote builds in B11642: Diff 16009.Aug 26 2022, 9:46 AM
• abosh accepted this revision.Aug 26 2022, 11:07 AM
• abosh added 2 blocking reviewer(s): ashoat, varun.

Don't know if @ashoat will be able to review anytime soon, but him or Varun should take a look at it. I think you can remove one or the other as blocking once they do, since @ashoat already looked at this diff and you seem to have incorporated his feedback.

ashoat accepted this revision.Aug 26 2022, 12:09 PM

Make sure to make the inline changes before landing

docs/dev_environment.md
327 ↗(On Diff #16009)
  1. "installs" appears twice
  2. s/anyway/anyways/
• abosh retitled this revision from Summary: updated dev env docs for protobuf edge case to [docs] updated dev env docs for protobuf edge case.Aug 26 2022, 1:26 PM
• abosh removed 1 blocking reviewer(s): varun.
This revision is now accepted and ready to land.Aug 26 2022, 1:26 PM
• derek updated this revision to Diff 16209.Sep 1 2022, 9:57 AM

removed duplicate "install"

This revision was landed with ongoing or failed builds.Sep 1 2022, 9:57 AM
Closed by commit rCOMM037d3f89d54a: [docs] updated dev env docs for protobuf edge case (authored by • derek). · Explain Why
This revision was automatically updated to reflect the committed changes.
• derek added a commit: rCOMM037d3f89d54a: [docs] updated dev env docs for protobuf edge case.
Harbormaster completed remote builds in B11806: Diff 16209.Sep 1 2022, 10:07 AM

Revision Contents
Changeset List

PathSize
docs/
2 lines

Diff 16211

View Options

docs/dev_environment.md

Loading...