[services] refactor subroutines to use new error types
ClosedPublic
Actions

Authored by varun on Jul 1 2022, 2:57 PM.

Details

Reviewers

tomek
• jim
• karol

Commits

rCOMM9c4399076d70: [services] refactor subroutines to use new error types

Summary

we can now use the DBItemError type in the subroutines that handle parsing/unpacking DynamoDB attributes

Depends on D4427

Test Plan

printed out some of the errors to see how they're logged. cargo build + cargo run server

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 1 2022, 2:57 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 1 2022, 2:57 PM

Harbormaster completed remote builds in B10216: Diff 14100.Jul 1 2022, 3:09 PM

varun requested review of this revision.Jul 1 2022, 3:09 PM

tomek accepted this revision.Jul 4 2022, 5:12 AM

tomek added inline comments.

services/identity/src/database.rs
57 ↗	(On Diff #14100)	Why do we remove an attribute here?

This revision is now accepted and ready to land.Jul 4 2022, 5:12 AM

varun added inline comments.Jul 5 2022, 7:39 AM

services/identity/src/database.rs
57 ↗	(On Diff #14100)	it's the same as `get` but it returns the actual value instead of a reference to it

Closed by commit rCOMM9c4399076d70: [services] refactor subroutines to use new error types (authored by varun). · Explain WhyJul 5 2022, 7:41 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9c4399076d70: [services] refactor subroutines to use new error types.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

147 lines

Diff 14192

View Options

services/identity/src/database.rs

[services] refactor subroutines to use new error typesClosedPublicActions