Introduce implementation of functions modifying navigation state after adding/removing user to list of selected and after exiting thread creation mode.
Details
Details
The component is not used in app yet. Tested it by performing different sequences of operations on users after introducing chat creation view in next diffs.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jacek/tmp
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/chat/chat-thread-composer.react.js | ||
|---|---|---|
| 59 ↗ | (On Diff #14392) | We could move this before the call to dispatch(...) like we do in onRemoveUserFromSelected? |
| web/chat/chat-thread-composer.react.js | ||
|---|---|---|
| 52–55 ↗ | (On Diff #14392) | Why do we check this? In dispatch, we're not using userInfo, but maybe this check protects us against some scenarios |
| web/chat/chat-thread-composer.react.js | ||
|---|---|---|
| 52–55 ↗ | (On Diff #14392) | Thanks for catching. I probably left it by accident after some changes. Selected user IDs are always from otherUserInfos so it's impossible for this condition to return here. Removing it will make dependency list shorter |