Page MenuHomePhabricator
Differential D4470

[web] Fix navigation after clicking on thread from thread list
ClosedPublic
Actions

Authored by • jacek on Jul 7 2022, 5:28 AM.
Tags
None
Referenced Files
F3396001: D4470.diff
Sun, Dec 1, 9:47 AM
Unknown Object (File)
Fri, Nov 29, 5:33 AM
Unknown Object (File)
Thu, Nov 28, 2:56 PM
Unknown Object (File)
Tue, Nov 26, 5:55 AM
Unknown Object (File)
Mon, Nov 18, 8:53 AM
Unknown Object (File)
Tue, Nov 12, 1:13 AM
Unknown Object (File)
Fri, Nov 8, 3:02 PM
Unknown Object (File)
Fri, Nov 8, 3:02 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
• abosh
Commits
rCOMM2a5d63b3766a: [web] Fix navigation after clicking on thread from thread list
Summary

Until now, useOnClickThread hook didn't specify chat mode.
After introducing chatMode, we need to make sure, that after clicking on any thread, chat creation mode will be closed.

Test Plan

Enter chat creation mode and select some users. Now after clicking thread in thread list on the left, creation mode will be closed.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/tmp
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Jul 7 2022, 5:28 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 7 2022, 5:28 AM
Harbormaster completed remote builds in B10344: Diff 14252.Jul 7 2022, 5:40 AM
• jacek requested review of this revision.Jul 7 2022, 5:40 AM
• jacek added a child revision: D4465: [web] Support chat creation in `ChatMessageListContainer`.Jul 7 2022, 5:58 AM
• jacek added a reviewer: • abosh.Jul 7 2022, 7:22 AM
• abosh accepted this revision.Jul 8 2022, 7:32 AM

Makes sense.

This revision is now accepted and ready to land.Jul 8 2022, 7:32 AM
• jacek updated this revision to Diff 14396.Jul 11 2022, 6:28 AM

rebase

Harbormaster completed remote builds in B10452: Diff 14396.Jul 11 2022, 6:41 AM
• jacek edited the summary of this revision. (Show Details)Jul 11 2022, 6:42 AM
• jacek added 1 blocking reviewer(s): tomek.
This revision now requires review to proceed.Jul 11 2022, 6:42 AM
tomek accepted this revision.Jul 19 2022, 4:43 AM
tomek added inline comments.
web/selectors/nav-selectors.js
147 ↗(On Diff #14396)

We can also consider making view a default mode

This revision is now accepted and ready to land.Jul 19 2022, 4:43 AM
Closed by commit rCOMM2a5d63b3766a: [web] Fix navigation after clicking on thread from thread list (authored by • jacek). · Explain WhyJul 26 2022, 3:06 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM2a5d63b3766a: [web] Fix navigation after clicking on thread from thread list.

Revision Contents
Changeset List

PathSize
web/
selectors/
2 lines

Diff 14252

View Options

web/selectors/nav-selectors.js

Loading...