This differential removes code that was used to modify messageStore on rehydrateActionType. Now that we do not persist messages in messageStore in redux, messages are always {} on rehydrateActionType, so the code never get executed.
Details
Details
This differential does not change app functionality, but only the way it works. So we expect the app to work exactly the same after this change.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-1350
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1270–1271 | It makes sense to remove this... it isn't doing anything anymore, since messages will be empty. But how are we going to handle filtering out local-only multimedia messages going forward? | |
| native/redux/persist.js | ||
| 384–386 | Confused why this change was combined with the message-reducer.js change. In the diff description you say:
Does specifying this rehydrate transform address this somehow? What's confusing to me is that the code in message-reducer.js is basically still doing the same thing it was before... so it doesn't make sense that removing that code requires adding this new code here. Note that I left a comment on Linear with some more questions. | |
Comment Actions
Remove rehydreate action transform since it is not necessary - it was a mistake to think it was needed.
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1269 ↗ | (On Diff #14455) | Should we just remove rehydrateActionType here? It's not strictly necessary in a reducer... if it does nothing, it seems best to remove it |
Comment Actions
Looks good, thanks for catching this.
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1269 ↗ | (On Diff #14455) | Agree with this, would reduce clutter in already |
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1269 ↗ | (On Diff #14455) | *Agree with this, would reduce clutter in already large file |