Page MenuHomePhabricator

[web] Rename thread to chat
ClosedPublic

Authored by inka on Jul 14 2022, 8:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 2:13 AM
Unknown Object (File)
Wed, May 8, 7:24 AM
Unknown Object (File)
Apr 9 2024, 3:42 AM
Unknown Object (File)
Apr 6 2024, 6:21 AM
Unknown Object (File)
Apr 3 2024, 7:58 PM
Unknown Object (File)
Apr 3 2024, 9:49 AM
Unknown Object (File)
Apr 2 2024, 8:47 PM
Unknown Object (File)
Apr 2 2024, 4:05 AM

Details

Summary

Linear issue:
https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in web

Test Plan

Checked if strings changed as expected in web.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jul 14 2022, 8:22 AM
abosh added inline comments.
web/modals/threads/confirm-leave-thread-modal.react.js
39 ↗(On Diff #14498)

Should this be capitalized to match the capitalized "t" in the old version of the code? In my opinion, the lowercase 'chat' looks nicer but wanted to confirm.

image.png (504×1 px, 66 KB)

This revision now requires changes to proceed.Jul 14 2022, 8:28 AM
ashoat requested changes to this revision.Jul 14 2022, 12:58 PM
ashoat added inline comments.
web/chat/thread-menu.react.js
217 ↗(On Diff #14498)
  1. Actually, in this rare case we are already using the correct term! "Promote" is something that applies to sidebars, which we are calling "threads" going forward.
  2. On native we use "Promote to channel", I think. Should we consider using the same language here?
web/modals/chat/sidebar-promote-modal.react.js
29 ↗(On Diff #14498)

Same comment as above – consider "Promote to channel" for consistency with native

35 ↗(On Diff #14498)

Let's say "Promoting a sidebar to a channel cannot be undone."

(I assume sidebar -> thread will be handled in a separate diff)

41 ↗(On Diff #14498)

Same comment as above – consider "Promote to channel" for consistency with native

web/modals/threads/confirm-leave-thread-modal.react.js
39 ↗(On Diff #14498)

I agree that lowercase is better here

web/modals/threads/subchannels/subchannels-modal.react.js
116 ↗(On Diff #14498)

Let's say "channel" instead of "chat", since subchannels can only exist inside another channel (or community, which we can consider a special kind of channel)

web/chat/thread-menu.react.js
217 ↗(On Diff #14498)

What should I do about the upper- and lowercase?

image.png (272×214 px, 12 KB)

We will then have the following buttons next to each other:
"Promote to channel"
"Leave Chat"
Since we're also changing "Yes, leave Chat" to "Yes, leave channel" maybe all buttons should have that casing convention?

web/modals/chat/sidebar-promote-modal.react.js
35 ↗(On Diff #14498)

Yes, I will be making separate diffs for sidebar -> thread renaming.

Rename chat to channel in some places, as requested

This looks great!!

Separately, one note regarding the whole diff stack – even though there might not be a formal dependency relationship, it would make reviewing a little easier if the related diffs (D4536, D4538, and this one) were put in a diff stack. More details about that workflow here.

A good rule of thumb is that if you have multiple commits in a branch, then you should have multiple diffs in a stack. In this case it's probably a good idea to have these commits in the same branch, so it's probably a good idea to have these diffs in a stack.

web/chat/thread-menu.react.js
217 ↗(On Diff #14498)

Good question!! Thanks for catching this.

I agree it would be good to be consistent. Can you submit a separate diff to change "Leave Chat" to "Leave chat"?

This revision is now accepted and ready to land.Jul 17 2022, 7:40 AM
inka added inline comments.
web/chat/thread-menu.react.js
217 ↗(On Diff #14498)

Sure, done!

inka marked 8 inline comments as done.Jul 18 2022, 4:35 AM

This looks great!!

Separately, one note regarding the whole diff stack – even though there might not be a formal dependency relationship, it would make reviewing a little easier if the related diffs (D4536, D4538, and this one) were put in a diff stack. More details about that workflow here.

A good rule of thumb is that if you have multiple commits in a branch, then you should have multiple diffs in a stack. In this case it's probably a good idea to have these commits in the same branch, so it's probably a good idea to have these diffs in a stack.

Right! I added appropriate parent and child revisions to my diffs