Linear issue: https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in keyserver and lib
Details
Details
- Reviewers
tomek ashoat • jacek - Commits
- rCOMM40369c86934f: [lib,keyserver] Rename thread to chat
Checked if strings changed as expected in web or mobile.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks great!! Just a couple of comments :)
| lib/shared/messages/create-sub-thread-message-spec.js | ||
|---|---|---|
| 129 ↗ | (On Diff #14495) | In this case I think it would actually be better to say "child channel", since a channel is the only kind of chat that can be a child (except sidebars) |
| lib/shared/thread-utils.js | ||
| 810 ↗ | (On Diff #14495) | Let's go with: Anybody in the parent channel can see an open child channel. COMMUNITY_OPEN_SUBTHREAD is actually specifically a channel. It can exist in a channel or in a community. I haven't previously thought about whether a community counts as a channel, to be honest... but I think it's good to be more specific here |
| 812 ↗ | (On Diff #14495) | Let's say "ancestor channels" |
| lib/shared/messages/create-sub-thread-message-spec.js | ||
|---|---|---|
| 129 ↗ | (On Diff #14495) | Another note: after reviewing D4539, realizing we should say "subchannel" instead of "child channel" |
| lib/shared/thread-utils.js | ||
| 810 ↗ | (On Diff #14495) | Another note: after reviewing D4539, realizing we should say "subchannel" instead of "child channel" |