Pin node to 16.13.0 to avoid import changes
Details
Details
- Reviewers
atul varun - Commits
- rCOMMf85ddafaee73: [Nix] Pin node to 16.13.0
nix develop cd keyserver yarn build-prod && yarn prod
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/node-16.13.0
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
To be completely honest, this is failing for me because of a different error:
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/jon/comm/comm/keyserver/dist/keyserver' imported from /home/jon/comm/comm/keyserver/
But it does remove the (node:1581718) ExperimentalWarning: --experimental-loader is an experimental feature warning, and yarn is using the correct version of node:
$ yarn node --version yarn node v1.22.19 v16.13.0 Done in 0.03s.
Comment Actions
This looks reasonable to me, but I don't "know nix."
| nix/overlay.nix | ||
|---|---|---|
| 40 ↗ | (On Diff #14506) | nit: It's 16.14 that introduced this requirement |
| nix/overlay.nix | ||
|---|---|---|
| 40 ↗ | (On Diff #14506) | Ah, I must have misread then |
Comment Actions
To be completely honest, this is failing for me because of a different error:
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/jon/comm/comm/keyserver/dist/keyserver' imported from /home/jon/comm/comm/keyserver/
yarn prod is probably failing because there is nothing in keyserver/dist. Node can't handle the files in keyserver/src directly... it needs Babel to transpile them into keyserver/dist first. yarn dev handles this for you automatically, but yarn prod needs you to handle it yourself by running yarn prod-build first. One way to learn more about the production build workflow is to take a look at keyserver/Dockerfile here.
But it does remove the (node:1581718) ExperimentalWarning: --experimental-loader is an experimental feature warning
That warning should still be present. I suspect it's missing because the above error causes a crash before the warning can be printed.