Page MenuHomePhabricator
Differential D4546

Summary: ran codegen for identity service CPP modules
AbandonedPublic
Actions

Authored by • derek on Jul 15 2022, 12:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 1:59 PM
Unknown Object (File)
Sat, Jun 29, 12:52 PM
Unknown Object (File)
Thu, Jun 27, 8:25 AM
Unknown Object (File)
Thu, Jun 27, 8:25 AM
Unknown Object (File)
Thu, Jun 27, 8:23 AM
Unknown Object (File)
Sat, Jun 22, 2:49 PM
Unknown Object (File)
Sat, Jun 22, 10:42 AM
Unknown Object (File)
Wed, Jun 12, 5:45 AM
View All 89 Files
Subscribers
• abosh
• adrian
ashoat
atul
• jon
tomek
varun

Details

Reviewers
ashoat
atul
• abosh
varun
Summary

These changes are autogenerated based on the work @varun is doing for the identity service in order to support sign in with ethereum.
parent linear
child linear

Test Plan

work with atul to run JSI codegen & bind the cpp modules to javascript

Diff Detail

Repository
rCOMM Comm
Branch
derek/generate
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Jul 15 2022, 12:41 PM
Herald added subscribers: • adrian, tomek. · View Herald TranscriptJul 15 2022, 12:41 PM
Harbormaster completed remote builds in B10560: Diff 14535.Jul 15 2022, 12:54 PM
• derek requested review of this revision.Jul 15 2022, 12:54 PM
• abosh requested changes to this revision.Jul 15 2022, 1:03 PM

Can you add a summary explaining the purpose or context for this diff?

This revision now requires changes to proceed.Jul 15 2022, 1:03 PM
• derek requested review of this revision.Aug 11 2022, 11:28 AM
• derek edited the summary of this revision. (Show Details)
• derek edited the test plan for this revision. (Show Details)

added context for the diff @abosh

• jon added a subscriber: • jon.Aug 11 2022, 11:58 AM

Should I added identity to https://phab.comm.dev/D4774 ?

Didn't add it initially because there was no generated identity files initially, but it looks like this adds them to the repo

ashoat requested changes to this revision.Aug 11 2022, 12:03 PM

Discussed IRL, we're actually gonna use Rust / tonic / tokio / corrosion for this instead

This revision now requires changes to proceed.Aug 11 2022, 12:03 PM
• derek abandoned this revision.Aug 11 2022, 12:04 PM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
_generated/
ios/
Comm.xcodeproj/
12 lines

Diff 14535

View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/identity.grpc.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/identity.grpc.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/identity.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/identity.pb.cc

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...