Adding mainline repo license to the Rust Cargo manifest files
ClosedPublic
Actions

Authored by • max on Jul 18 2022, 5:18 AM.

Details

Reviewers

varun
• karol
ashoat
• jon

Commits

rCOMM84ee95dc7a11: Adding mainline repo license to the Rust Cargo manifest files

Summary

This diff introduces adding and fixing the license in the Rust Cargo manifest files inside the project.
The license is set according to the mainline repo license (@ashoat comment in D4534).

Test Plan

Running cargo b or cargo check produces no errors.

Diff Detail

Repository

rCOMM Comm

Branch

add-fix-license-in-cargo

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jul 18 2022, 5:18 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 18 2022, 5:18 AM

Adding @ashoat as blocking because it's license-related changes.

• max mentioned this in D4534: [services] Tunnelbroker - Add Cargo manifest file.Jul 18 2022, 5:22 AM

Harbormaster failed remote builds in B10579: Diff 14567!Jul 18 2022, 5:24 AM

Android build failure is unrelated to these changes it's about a connection refused from the OpenSSL website (seems it was down).

It should just be "BSD-3-Clause", not "BSD 3-Clause 'New' or 'Revised' License". https://spdx.github.io/license-list-data/BSD-3-Clause.html

Also, do we really need a license for the binaries?

This revision now requires changes to proceed.Jul 18 2022, 8:16 AM

Change license name to the BSD-3-Clause.

Thanks for fixing this. Still curious if others think we need a license for the binaries

In D4552#129932, @varun wrote:

It should just be "BSD-3-Clause", not "BSD 3-Clause 'New' or 'Revised' License". https://spdx.github.io/license-list-data/BSD-3-Clause.html

Seems to be that... I've changed the license's name.

Also, do we really need a license for the binaries?

I think it's a legal requirement, but curious about @ashoat comment. If we don't need to attach a license, I'll just remove it everywhere in the Cargo.toml.

Harbormaster completed remote builds in B10588: Diff 14579.Jul 18 2022, 11:11 AM

I don't think we need to list a license here unless we publish these crates. If we publish then it's probably a good idea to list a license. Either way we should avoid introducing a different license for any of these. Probably no downside in adding the license to the individual Cargo.tomls

This revision is now accepted and ready to land.Jul 18 2022, 11:48 AM

Closed by commit rCOMM84ee95dc7a11: Adding mainline repo license to the Rust Cargo manifest files (authored by • max). · Explain WhyJul 18 2022, 12:12 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM84ee95dc7a11: Adding mainline repo license to the Rust Cargo manifest files.