[services] Backup - send log - add case for DB
ClosedPublic
Actions

Authored by • karol on Jul 18 2022, 7:00 AM.

Details

Reviewers

tomek

Commits

rCOMM9e6d704de946: [services] Backup - send log - add case for DB

Summary

Depends on D4438

We want to handle a situation when we save the records in the database (it didn't work in the tests).
We should set the persistence method to the DB when receiving a "tiny" chunk - "tiny" means below LOG_DATA_SIZE_DATABASE_LIMIT that is 400KiB

Test Plan

full test plan in D4556, for now the service builds

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 18 2022, 7:00 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 18 2022, 7:00 AM

• karol edited the summary of this revision. (Show Details)Jul 18 2022, 7:05 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D4438: [services] Backup - pull attachment holders out of the data section.

• karol added a child revision: D4555: [services] Backup - pull backup - change logic to use att holders out of data section.Jul 18 2022, 7:07 AM

Harbormaster completed remote builds in B10583: Diff 14572.Jul 18 2022, 7:13 AM

• karol requested review of this revision.Jul 18 2022, 7:13 AM

• karol added a child revision: D4571: [services] Backup - Add helper method for extra data.Jul 19 2022, 1:30 AM

• karol removed a child revision: D4555: [services] Backup - pull backup - change logic to use att holders out of data section.

We want to handle a situation when we save the records in the database (it didn't work in the tests).

Could you explain it a little more? How would we want to handle it? What do you mean by that it didn't work in the test?

services/backup/src/Reactors/server/SendLogReactor.cpp
101–104 ↗	(On Diff #14572)	Can we make this message more precise? E.g. what `bigger` means in this case? Is 1KB big enough? Or 1MB? We should make this message helpful when debugging.

This revision now requires changes to proceed.Jul 19 2022, 3:27 AM

In D4554#130404, @palys-swm wrote:

We want to handle a situation when we save the records in the database (it didn't work in the tests).

Could you explain it a little more? How would we want to handle it? What do you mean by that it didn't work in the test?

I missed that we should set the persistence method to the DB when receiving a "tiny" chunk - "tiny" means below LOG_DATA_SIZE_DATABASE_LIMIT that is 400KiB. I will put that in the description.

services/backup/src/Reactors/server/SendLogReactor.cpp
101–104 ↗	(On Diff #14572)	Sure `tiny` here means less than the DB limit (`LOG_DATA_SIZE_DATABASE_LIMIT`) which is `400KiB` I will update the message.