Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
services/backup/src/Reactors/server/PullBackupReactor.cpp | ||
---|---|---|
87–90 ↗ | (On Diff #14618) | Are you sure this return should be conditional? Also, setting state to LOGS should be the last operation, just before the return. |
services/backup/src/Reactors/server/PullBackupReactor.cpp | ||
---|---|---|
87–90 ↗ | (On Diff #14618) | I think so.
No, it's ok. The state should be set to sending logs regardless of whether we send the last message with the internal buffer for compaction or we just proceed to handle the logs. |