Page MenuHomePhabricator
Differential D4556

[services] Backup - pull backup - change tests
ClosedPublic
Actions

Authored by • karol on Jul 18 2022, 7:00 AM.
Tags
None
Referenced Files
F3398635: D4556.diff
Sun, Dec 1, 11:47 PM
Unknown Object (File)
Sun, Nov 10, 10:05 PM
Unknown Object (File)
Sat, Nov 9, 12:42 PM
Unknown Object (File)
Sat, Nov 9, 11:59 AM
Unknown Object (File)
Sat, Nov 9, 10:42 AM
Unknown Object (File)
Sat, Nov 9, 9:09 AM
Unknown Object (File)
Tue, Nov 5, 10:50 AM
Unknown Object (File)
Oct 23 2024, 9:14 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMM499626f0d48d: [services] Backup - pull backup - change tests
Summary

Depends on D4598

Test all the changes from the last 3 diffs.

Test Plan
cd services
yarn run-blob-service-in-sandbox
yarn run-backup-service-in-sandbox

yarn run-integration-tests backup

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jul 18 2022, 7:00 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 18 2022, 7:00 AM
• karol mentioned this in D4554: [services] Backup - send log - add case for DB.Jul 18 2022, 7:05 AM
• karol mentioned this in D4555: [services] Backup - pull backup - change logic to use att holders out of data section.Jul 18 2022, 7:07 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
Harbormaster completed remote builds in B10585: Diff 14574.Jul 18 2022, 7:24 AM
• karol requested review of this revision.Jul 18 2022, 7:24 AM
• karol mentioned this in D4571: [services] Backup - Add helper method for extra data.Jul 19 2022, 1:30 AM
tomek accepted this revision.Jul 21 2022, 3:12 AM

It would be a lot better if formatting and logic changes were split into separate diffs.

This revision is now accepted and ready to land.Jul 21 2022, 3:12 AM
• karol edited the summary of this revision. (Show Details)Jul 21 2022, 6:06 AM
• karol added a parent revision: D4598: [services] Tests - Run formatter.
• karol removed a parent revision: D4555: [services] Backup - pull backup - change logic to use att holders out of data section.

Ok, put formatting in D4598

tomek added a comment.Jul 22 2022, 2:02 AM

It seems like you need to rebase this diff as it now contains both original changes and the ones moved to D4598

• karol updated this revision to Diff 14802.Jul 22 2022, 2:29 AM
• karol edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B10761: Diff 14802.Jul 22 2022, 2:41 AM
• karol updated this revision to Diff 14856.Jul 25 2022, 7:01 AM

rebase

This revision was landed with ongoing or failed builds.Jul 25 2022, 7:14 AM
Closed by commit rCOMM499626f0d48d: [services] Backup - pull backup - change tests (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol mentioned this in rCOMM9e6d704de946: [services] Backup - send log - add case for DB.
• karol mentioned this in rCOMM5f4ad89d9fb0: [services] Backup - Add helper method for extra data.
• karol mentioned this in rCOMM3cf058b5c57f: [services] Backup - pull backup - change logic to use att holders out of data….
• karol added a commit: rCOMM499626f0d48d: [services] Backup - pull backup - change tests.
Harbormaster completed remote builds in B10803: Diff 14856.Jul 25 2022, 7:16 AM

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
backup/
67 lines
5 lines
lib/
6 lines

Diff 14574

View Options

services/commtest/tests/backup/pull_backup.rs

Loading...
View Options

services/commtest/tests/backup_test.rs

Loading...
View Options

services/commtest/tests/lib/tools.rs

Loading...