[services] rename registration table to users table
ClosedPublic
Actions

Authored by varun on Jul 18 2022, 1:23 PM.

Details

Reviewers

atul
• max
tomek
• karol

Commits

rCOMM296a7ba90185: [services] rename registration table to users table

Summary

we're going to repurpose this table to store more than just registration data (i.e. username, wallet address, auth type, user's public key). this rename is the first step

Test Plan

ran the service locally and made sure i could read/write to the renamed DDB table

Diff Detail

Repository

rCOMM Comm

Branch

eng-1421 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jul 18 2022, 1:23 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptJul 18 2022, 1:23 PM

Harbormaster completed remote builds in B10591: Diff 14583.Jul 18 2022, 1:36 PM

varun requested review of this revision.Jul 18 2022, 1:36 PM

varun added a child revision: D4561: [services] use client update_item method instead of put_item for registration data.Jul 18 2022, 1:48 PM

varun added a child revision: D4562: [services] helper to update the users table.Jul 18 2022, 2:14 PM

varun removed a child revision: D4561: [services] use client update_item method instead of put_item for registration data.Jul 18 2022, 2:20 PM

tomek accepted this revision.Jul 19 2022, 1:45 AM

• karol accepted this revision.Jul 19 2022, 1:57 AM

Seems like we'll need to update D4525 for this name change as well

In D4559#130587, @ashoat wrote:

Seems like we'll need to update D4525 for this name change as well

will update now before landing!

varun removed 1 blocking reviewer(s): atul.Jul 19 2022, 11:25 AM

This revision is now accepted and ready to land.Jul 19 2022, 11:25 AM

Closed by commit rCOMM296a7ba90185: [services] rename registration table to users table (authored by varun). · Explain WhyJul 19 2022, 11:28 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM296a7ba90185: [services] rename registration table to users table.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

constants.rs

7 lines

database.rs

26 lines

Diff 14583

View Options

services/identity/src/constants.rs