Page MenuHomePhabricator
Differential D4574

[web] Hide "Users in parent channel" header for threads without parent in `AddMembersModal`
ClosedPublic
Actions

Authored by • jacek on Jul 19 2022, 3:50 AM.
Tags
None
Referenced Files
F2152969: D4574.diff
Sun, Jun 30, 4:27 PM
Unknown Object (File)
Sat, Jun 22, 9:56 PM
Unknown Object (File)
Fri, Jun 21, 5:14 PM
Unknown Object (File)
Fri, Jun 21, 5:14 PM
Unknown Object (File)
Fri, Jun 21, 5:14 PM
Unknown Object (File)
Fri, Jun 21, 5:08 PM
Unknown Object (File)
Thu, Jun 20, 5:54 PM
Unknown Object (File)
Thu, Jun 20, 8:29 AM
View All 44 Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM832036c9acb6: [web] Hide "Users in parent channel" header for threads without parent in…
Summary

The diff is solution for: https://linear.app/comm/issue/ENG-1396/addmembersmodal-on-web-shows-users-in-parent-channel-for-community
It provides additional check if channel (that we want to add users to) has parent channel, and hides "Users in parent channel" label if there is no parent channel

Screenshot_Google Chrome_2022-07-19_125821.png (384×633 px, 21 KB)

Test Plan

Tested the modal in Genesis and one manually created COMMUNITY_ROOT thread (to achive something similar to Comm channel in production, where the issue appeared) and confirmed, that the header is not displayed and the modal looks good.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/add-members-fix
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
members/
7 lines
22 lines
1 line

Diff 14629

View Options

web/modals/threads/members/add-members-group.react.js

Loading...
View Options

web/modals/threads/members/add-members-list.react.js

Loading...
View Options

web/modals/threads/members/add-members-modal.react.js

Loading...