Page MenuHomePhabricator

[web] Hide "Users in parent channel" header for threads without parent in `AddMembersModal`
ClosedPublic

Authored by jacek on Jul 19 2022, 3:50 AM.
Tags
None
Referenced Files
F3363139: D4574.diff
Mon, Nov 25, 12:26 AM
Unknown Object (File)
Tue, Nov 19, 4:46 PM
Unknown Object (File)
Tue, Nov 19, 4:46 PM
Unknown Object (File)
Tue, Nov 19, 4:46 PM
Unknown Object (File)
Tue, Nov 19, 4:45 PM
Unknown Object (File)
Oct 17 2024, 9:51 PM
Unknown Object (File)
Oct 17 2024, 9:51 PM
Unknown Object (File)
Oct 17 2024, 9:51 PM

Details

Summary

The diff is solution for: https://linear.app/comm/issue/ENG-1396/addmembersmodal-on-web-shows-users-in-parent-channel-for-community
It provides additional check if channel (that we want to add users to) has parent channel, and hides "Users in parent channel" label if there is no parent channel

Screenshot_Google Chrome_2022-07-19_125821.png (384×633 px, 21 KB)

Test Plan

Tested the modal in Genesis and one manually created COMMUNITY_ROOT thread (to achive something similar to Comm channel in production, where the issue appeared) and confirmed, that the header is not displayed and the modal looks good.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable