We want to use glog in other services, not only tunnelbroker. Therefore, I think we should move initializing function to the global tools so it can be accessed from the blob and the backup as well.
Details
Details
cd services yarn run-tunnelbroker-in-sandbox
Tunnelbroker builds without problems.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/tunnelbroker/src/server.cpp | ||
|---|---|---|
| 42 ↗ | (On Diff #14767) | Is there a downside of using argv[0]? |
| services/tunnelbroker/src/server.cpp | ||
|---|---|---|
| 42 ↗ | (On Diff #14767) | argv[0] is something like ./cmake/build/bin/tunnelbroker. I just find it clearer to hardcode the short name. |
| services/tunnelbroker/src/server.cpp | ||
|---|---|---|
| 42 ↗ | (On Diff #14767) | Ok, that makes sense. Agree, your approach is better. |