[services] Backup - Remove couts or replace them with glog
ClosedPublic
Actions

Authored by • karol on Jul 21 2022, 3:44 AM.

Details

Reviewers

tomek
• max

Commits

Summary

Depends on D4588

Adding an initialization of the glog functionalities.
Removing std::couts or replacing them with glog functions for the backup service.

Test Plan

cd services
yarn run-backup-service-in-sandbox

Builds ok

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 3:45 AM

• karol edited the test plan for this revision. (Show Details)

retrigger CI

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 4:04 AM

Services built properly

• max added inline comments.

services/backup/src/server.cpp
27 ↗	(On Diff #14760)	Same comment as here. We can add where it listens in a follow-up.

This revision is now accepted and ready to land.Jul 21 2022, 7:03 AM

This revision now requires review to proceed.Jul 21 2022, 7:38 AM

tomek added inline comments.

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
108 ↗	(On Diff #14760)	Can we keep these logs?

This revision is now accepted and ready to land.Jul 22 2022, 3:30 AM

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
108 ↗	(On Diff #14760)	Once we're done discussing the way we do logs, I'm going to add logs for every action taken by the reactors. For now, I just wanted to clear things out so we don't have any leftovers.
services/backup/src/server.cpp
27 ↗	(On Diff #14760)	OK