Page MenuHomePhabricator
Differential D4592

[services] Tunnelbroker - remove include iostream
ClosedPublic
Actions

Authored by • karol on Jul 21 2022, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 8:54 PM
Unknown Object (File)
Fri, Dec 27, 8:54 PM
Unknown Object (File)
Fri, Dec 27, 8:54 PM
Unknown Object (File)
Fri, Dec 27, 8:48 PM
Unknown Object (File)
Wed, Dec 25, 11:02 PM
Unknown Object (File)
Thu, Dec 19, 2:01 AM
Unknown Object (File)
Thu, Dec 19, 2:01 AM
Unknown Object (File)
Thu, Dec 19, 2:01 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
• max
Commits
rCOMM2eb10c1818e3: [services] Tunnelbroker - remove include iostream
Summary

Depends on D4591

Removing #include <iostream> everywhere. This include was used for std::cout and since we quit using it, we can clear out all such includes.

Test Plan

Tunnelbroker builds.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jul 21 2022, 3:45 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 21 2022, 3:45 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 3:48 AM
Harbormaster failed remote builds in B10712: Diff 14751!
• karol edited the summary of this revision. (Show Details)Jul 21 2022, 4:06 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D4591: [services] Lib - Remove couts or replace them with glog.
• karol added a child revision: D4593: [services] Backup - remove include iostream.
• karol updated this revision to Diff 14763.Jul 21 2022, 4:08 AM
• karol edited the summary of this revision. (Show Details)

CI

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 4:09 AM
Harbormaster failed remote builds in B10724: Diff 14763!
• karol requested review of this revision.Jul 21 2022, 4:18 AM

Services built properly

• max accepted this revision.Jul 21 2022, 6:01 AM
This revision is now accepted and ready to land.Jul 21 2022, 6:01 AM
• karol added 1 blocking reviewer(s): tomek.Jul 21 2022, 7:38 AM
This revision now requires review to proceed.Jul 21 2022, 7:38 AM
tomek accepted this revision.Jul 22 2022, 3:44 AM

It might be a little better to remove imports in diffs that made them unused

This revision is now accepted and ready to land.Jul 22 2022, 3:44 AM
This revision was landed with ongoing or failed builds.Jul 26 2022, 7:11 AM
Closed by commit rCOMM2eb10c1818e3: [services] Tunnelbroker - remove include iostream (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM2eb10c1818e3: [services] Tunnelbroker - remove include iostream.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
DeliveryBroker/
1 line
Service/
1 line
Tools/
1 line
2 lines
1 line
1 line

Diff 14974

View Options

services/tunnelbroker/src/DeliveryBroker/DeliveryBroker.h

Loading...
View Options

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.h

Loading...
View Options

services/tunnelbroker/src/Tools/ConfigManager.h

Loading...
View Options

services/tunnelbroker/src/Tools/CryptoTools.cpp

Loading...
View Options

services/tunnelbroker/src/Tools/Tools.cpp

Loading...
View Options

services/tunnelbroker/src/server.cpp

Loading...