Page MenuHomePhabricator
Differential D4604

[Nix] Add support for tunnelbroker build
ClosedPublic
Actions

Authored by • jon on Jul 21 2022, 1:04 PM.
Tags
None
Referenced Files
F2110766: D4604.diff
Tue, Jun 25, 8:58 PM
F2108948: D4604.diff
Tue, Jun 25, 2:54 PM
Unknown Object (File)
Mon, Jun 24, 5:43 AM
Unknown Object (File)
Sun, Jun 23, 4:28 PM
Unknown Object (File)
Sat, Jun 22, 9:11 AM
Unknown Object (File)
Sat, Jun 22, 9:11 AM
Unknown Object (File)
Sat, Jun 22, 9:11 AM
Unknown Object (File)
Sat, Jun 22, 9:11 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
varun
• max
Commits
rCOMMb20c14d3b33b: [Nix] Add support for tunnelbroker build
Summary

Only the dependencies being added to the nix develop shell

The related CMake changes were causing the gates to crash without the
docker fixes

Test Plan

nix develop and in a later diff, build tunnelbroker with cmake

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 21 2022, 1:04 PM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 21 2022, 1:04 PM
• jon added a parent revision: D4483: [Nix] Support building Android through gradle on Linux.Jul 21 2022, 1:05 PM
Harbormaster completed remote builds in B10753: Diff 14793.Jul 21 2022, 1:20 PM
• jon requested review of this revision.Jul 21 2022, 1:20 PM
• jon updated this revision to Diff 14822.Jul 22 2022, 12:55 PM

Remove CMake changes

Harbormaster completed remote builds in B10781: Diff 14822.Jul 22 2022, 1:07 PM
• max accepted this revision.Jul 25 2022, 10:20 AM

Looks ok to me!

This revision is now accepted and ready to land.Jul 25 2022, 10:20 AM
• jon updated this revision to Diff 14899.Jul 25 2022, 8:51 PM

Rebase

Harbormaster completed remote builds in B10836: Diff 14899.Jul 25 2022, 9:04 PM
• jon added a parent revision: D4629: [Nix] Patch aws-sdk-cpp to automatically find Aws.h.Jul 25 2022, 9:09 PM
• jon removed a parent revision: D4483: [Nix] Support building Android through gradle on Linux.
• jon added a child revision: D3867: [services] Export comm's grpc generated files as cmake project.
• jon requested review of this revision.Jul 26 2022, 8:14 AM

Just going to request a review since this has been reduced quite a bit since I first threw it up

varun accepted this revision.Jul 26 2022, 10:37 AM
This revision is now accepted and ready to land.Jul 26 2022, 10:37 AM
• jon added a parent revision: D4298: [services] Export sqlite_orm as CMake project.Jul 26 2022, 6:08 PM
• jon removed a parent revision: D4629: [Nix] Patch aws-sdk-cpp to automatically find Aws.h.
Closed by commit rCOMMb20c14d3b33b: [Nix] Add support for tunnelbroker build (authored by • jon). · Explain WhyJul 27 2022, 12:03 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMb20c14d3b33b: [Nix] Add support for tunnelbroker build.
• jon added a child revision: D4646: [Nix] Update nixpkgs pin.Jul 27 2022, 6:11 PM
• jon removed a child revision: D4646: [Nix] Update nixpkgs pin.
• jon removed a child revision: D3867: [services] Export comm's grpc generated files as cmake project.Jul 28 2022, 5:37 PM
• jon mentioned this in D4488: [Nix] Add support for tunnelbroker build.Jul 29 2022, 10:00 AM
• jon removed a parent revision: D4298: [services] Export sqlite_orm as CMake project.Aug 17 2022, 9:43 AM

Revision Contents
Changeset List

PathSize
nix/
8 lines

Diff 14822

View Options

nix/dev-shell.nix

Loading...