Paths

Table of Contentst

1/1
.lintstagedrc.js

Differential D4620

[lintstaged] Rename `keyServer` => `keyserver`
ClosedPublic
Actions

Authored by atul on Jul 25 2022, 7:50 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 25, 3:57 AM

	Unknown Object (File)
	Tue, Mar 18, 4:47 AM

	Unknown Object (File)
	Tue, Mar 18, 2:00 AM

	Unknown Object (File)
	Sun, Mar 16, 10:34 AM

	Unknown Object (File)
	Wed, Mar 12, 4:14 AM

	Unknown Object (File)
	Sat, Mar 8, 6:42 AM

	Unknown Object (File)
	Sat, Mar 8, 6:42 AM

	Unknown Object (File)
	Sat, Mar 8, 6:42 AM

Subscribers

Details

Reviewers

tomek
• jacek
• abosh
varun

Commits

rCOMMc95753960ef5: [lintstaged] Rename `keyServer` => `keyserver`

Summary

keyserver is one "word" so shouldn't be camelCase.

Test Plan

Made a change in /keyserver and made sure that the lintstaged steps ran as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jul 25 2022, 7:50 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJul 25 2022, 7:50 AM

Harbormaster completed remote builds in B10809: Diff 14868.Jul 25 2022, 8:02 AM

atul requested review of this revision.Jul 25 2022, 8:02 AM

• abosh accepted this revision.Jul 25 2022, 8:47 AM

This revision is now accepted and ready to land.Jul 25 2022, 8:47 AM

atul added a reviewer: varun. atul added 1 blocking reviewer(s): tomek.Jul 25 2022, 8:48 AM

This revision now requires review to proceed.Jul 25 2022, 8:48 AM

ah, pointed this out in another diff before i saw this one

atul removed 1 blocking reviewer(s): tomek.Jul 25 2022, 9:00 AM

This revision is now accepted and ready to land.Jul 25 2022, 9:00 AM

rebase after addressing feedback

Harbormaster failed remote builds in B10813: Diff 14872!Jul 25 2022, 9:08 AM

Harbormaster completed remote builds in B10813: Diff 14872.Jul 25 2022, 9:56 AM

Closed by commit rCOMMc95753960ef5: [lintstaged] Rename `keyServer` => `keyserver` (authored by atul). · Explain WhyJul 25 2022, 10:02 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc95753960ef5: [lintstaged] Rename `keyServer` => `keyserver`.

• abosh mentioned this in D4779: [lintstaged] Add cmake-lint to lintstagedrc.Aug 9 2022, 10:15 AM

Revision Contents
Changeset List

Path

Size

.lintstagedrc.js

4 lines

Diff 14874

.lintstagedrc.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };