Page MenuHomePhabricator
Differential D4620

[lintstaged] Rename `keyServer` => `keyserver`
ClosedPublic
Actions

Authored by atul on Jul 25 2022, 7:50 AM.
Tags
None
Referenced Files
F1773113: D4620.diff
Wed, May 15, 9:43 PM
Unknown Object (File)
Apr 14 2024, 5:08 AM
Unknown Object (File)
Apr 14 2024, 5:08 AM
Unknown Object (File)
Apr 14 2024, 5:08 AM
Unknown Object (File)
Apr 14 2024, 5:08 AM
Unknown Object (File)
Apr 13 2024, 5:44 AM
Unknown Object (File)
Mar 28 2024, 2:30 PM
Unknown Object (File)
Mar 28 2024, 2:30 PM
View All 75 Files
Subscribers
• adrian
ashoat

Details

Reviewers
tomek
• jacek
• abosh
varun
Commits
rCOMMc95753960ef5: [lintstaged] Rename `keyServer` => `keyserver`
Summary

keyserver is one "word" so shouldn't be camelCase.

Test Plan

Made a change in /keyserver and made sure that the lintstaged steps ran as expected.

Diff Detail

Repository
rCOMM Comm
Branch
landjuly25 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jul 25 2022, 7:50 AM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJul 25 2022, 7:50 AM
Harbormaster completed remote builds in B10809: Diff 14868.Jul 25 2022, 8:02 AM
atul requested review of this revision.Jul 25 2022, 8:02 AM
• abosh accepted this revision.Jul 25 2022, 8:47 AM
This revision is now accepted and ready to land.Jul 25 2022, 8:47 AM
atul added a reviewer: varun. atul added 1 blocking reviewer(s): tomek.Jul 25 2022, 8:48 AM
This revision now requires review to proceed.Jul 25 2022, 8:48 AM
varun accepted this revision.Jul 25 2022, 8:56 AM

ah, pointed this out in another diff before i saw this one

atul removed 1 blocking reviewer(s): tomek.Jul 25 2022, 9:00 AM
This revision is now accepted and ready to land.Jul 25 2022, 9:00 AM
atul updated this revision to Diff 14872.Jul 25 2022, 9:06 AM

rebase after addressing feedback

Harbormaster failed remote builds in B10813: Diff 14872!Jul 25 2022, 9:08 AM
Harbormaster completed remote builds in B10813: Diff 14872.Jul 25 2022, 9:56 AM
Closed by commit rCOMMc95753960ef5: [lintstaged] Rename `keyServer` => `keyserver` (authored by atul). · Explain WhyJul 25 2022, 10:02 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc95753960ef5: [lintstaged] Rename `keyServer` => `keyserver`.
• abosh mentioned this in D4779: [lintstaged] Add cmake-lint to lintstagedrc.Aug 9 2022, 10:15 AM

Revision Contents
Changeset List

PathSize
4 lines

Diff 14872

View Options

.lintstagedrc.js

Loading...