Page MenuHomePhabricator
Differential D4622

[iOS] Exclude `arm64` Simulator architecture for `CommTests`
ClosedPublic
Actions

Authored by atul on Jul 25 2022, 9:01 AM.
Tags
None
Referenced Files
F2205774: D4622.id14992.diff
Sat, Jul 6, 11:22 PM
F2205772: D4622.id14982.diff
Sat, Jul 6, 11:22 PM
F2205771: D4622.id14870.diff
Sat, Jul 6, 11:22 PM
F2205766: D4622.id.diff
Sat, Jul 6, 11:22 PM
F2205765: D4622.diff
Sat, Jul 6, 11:22 PM
Unknown Object (File)
Sat, Jul 6, 9:52 AM
Unknown Object (File)
Fri, Jul 5, 2:34 AM
Unknown Object (File)
Thu, Jul 4, 10:28 PM
View All Files
Subscribers
• adrian

Details

Reviewers
• abosh
ashoat
tomek
• jacek
• karol
Commits
rCOMMba902f61479e: [iOS] Exclude `arm64` Simulator architecture for `CommTests`
Summary

Exclude arm64 architecture for iOS Simulator.. matching what we have for the Comm target.

Allows us to run XCTests on Apple silicon machines.

Test Plan

Ran CryptoTests from Xcode GUI and from commandline:

xcodebuild test -workspace Comm.xcworkspace -scheme Comm -destination name="iPhone 13"

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jul 25 2022, 9:01 AM
Herald added a subscriber: • adrian. · View Herald TranscriptJul 25 2022, 9:01 AM
atul added a child revision: D4621: [CI] Add `XCTest`s to GitHub Actions CI.Jul 25 2022, 9:01 AM

Adding @ashoat as first pass reviewer since he has context on why we excluded arm64 for iOS Simulator for Comm target.

Adding @karol as a reviewer since he initially wrote CryptoTests.

Harbormaster completed remote builds in B10811: Diff 14870.Jul 25 2022, 9:14 AM
atul requested review of this revision.Jul 25 2022, 9:14 AM
ashoat accepted this revision.Jul 25 2022, 11:24 AM

Ugh yeah, I think we need this because ffmpeg or some other dependency can't handle running on arm64

This revision is now accepted and ready to land.Jul 25 2022, 11:24 AM
atul updated this revision to Diff 14982.Jul 26 2022, 7:59 AM

rebase after cherrypicking and before landing

atul added a comment.Jul 26 2022, 8:09 AM

Should've included this in Test Plan, but:

xcodebuild test -workspace Comm.xcworkspace -scheme Comm -destination name="iPhone 13"

to run the tests from command line.

atul edited the test plan for this revision. (Show Details)Jul 26 2022, 8:09 AM
Harbormaster completed remote builds in B10895: Diff 14982.Jul 26 2022, 8:13 AM
Closed by commit rCOMMba902f61479e: [iOS] Exclude `arm64` Simulator architecture for `CommTests` (authored by atul). · Explain WhyJul 26 2022, 8:48 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMba902f61479e: [iOS] Exclude `arm64` Simulator architecture for `CommTests`.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
2 lines

Diff 14870

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...