[services] consolidate ddb client code, small refactor
ClosedPublic
Actions

Authored by varun on Jul 25 2022, 12:49 PM.

Details

Reviewers

tomek
• karol

Commits

rCOMM7c7831094dec: [services] consolidate ddb client code, small refactor

Summary

consolidated some of the client code to minimize the number of calls we make to DynamoDB. also changed the PAKE_USER_ prefix to USER in constants.rs since the table holds more than just PAKE data now.

Test Plan

cargo build, tested that the update expression worked by creating, updating an item in the DDB table

Diff Detail

Repository

rCOMM Comm

Branch

identity

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jul 25 2022, 12:49 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 25 2022, 12:49 PM

Harbormaster completed remote builds in B10827: Diff 14890.Jul 25 2022, 1:02 PM

varun requested review of this revision.Jul 25 2022, 1:02 PM

fix update expression syntax

Harbormaster completed remote builds in B10830: Diff 14893.Jul 25 2022, 1:37 PM

varun added a child revision: D4628: [services] use username and public key from registration request.Jul 25 2022, 1:39 PM

• karol accepted this revision.Jul 26 2022, 6:09 AM

• karol added inline comments.

services/identity/src/database.rs
84–86 ↗	(On Diff #14893)	Clever solution, nice.
125 ↗	(On Diff #14893)	How does it work? I mean, don't we need some sort of delimiter for multiple ops?

tomek accepted this revision.Jul 26 2022, 6:38 AM

tomek added inline comments.

services/identity/src/database.rs
90–98 ↗	(On Diff #14893)	When only one arm of match expression does useful job, we should use `if let` instead

This revision is now accepted and ready to land.Jul 26 2022, 6:38 AM

varun added inline comments.Jul 26 2022, 8:38 AM

services/identity/src/database.rs
90–98 ↗	(On Diff #14893)	will fix before landing
125 ↗	(On Diff #14893)	I originally thought we needed a comma delimiter but turns out the keyword `SET` is enough for the parser to split up the expression