Page MenuHomePhabricator
Differential D4631

[services] Tests - Backup - Initialize performance tests
ClosedPublic
Actions

Authored by • karol on Jul 26 2022, 2:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 12:15 PM
Unknown Object (File)
Wed, Jun 26, 7:13 AM
Unknown Object (File)
Wed, Jun 26, 7:13 AM
Unknown Object (File)
Wed, Jun 26, 7:13 AM
Unknown Object (File)
Wed, Jun 26, 7:13 AM
Unknown Object (File)
Wed, Jun 26, 7:13 AM
Unknown Object (File)
Wed, Jun 26, 7:12 AM
Unknown Object (File)
Wed, Jun 26, 7:06 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMMfcb69c145fde: [services] Tests - Backup - Initialize performance tests
Summary

Depends on D4585

Initializing performance tests for the backup service. This just generates the data to be sent and sets up a basic structure of the code

Test Plan
cd services
yarn run-performance-tests backup 1

This should compile but it will not do anything really.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jul 26 2022, 2:33 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 26 2022, 2:33 AM
• karol edited the summary of this revision. (Show Details)Jul 26 2022, 2:44 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4585: [services] Tests - Improve logging for Blob tests.
• karol added a child revision: D4632: [services] Tests - Backup - Add attachments for backups.
• karol added inline comments.
services/commtest/tests/backup_performance_test.rs
62–99 ↗(On Diff #14923)

This should go in a separate diff

Harbormaster completed remote builds in B10860: Diff 14923.Jul 26 2022, 2:46 AM
• karol requested review of this revision.Jul 26 2022, 2:46 AM
• karol added a child revision: D4637: [services] Tests - Backup - Create new backup.Jul 26 2022, 2:53 AM
• karol removed a child revision: D4632: [services] Tests - Backup - Add attachments for backups.
• karol planned changes to this revision.Jul 26 2022, 3:03 AM
• karol added inline comments.
services/commtest/tests/backup_performance_test.rs
24–29 ↗(On Diff #14923)

Should be changed like in D4581

• karol updated this revision to Diff 14932.Jul 26 2022, 3:04 AM
• karol edited the summary of this revision. (Show Details)

change number of threads

Harbormaster completed remote builds in B10869: Diff 14932.Jul 26 2022, 3:15 AM
tomek accepted this revision.Jul 26 2022, 4:35 AM

We can consider extracting some common logic from this and D4581. We can e.g. create a function that determines number of threads and use it in both places.

services/commtest/tests/backup_performance_test.rs
15–19 ↗(On Diff #14932)

The variable is duplicated

This revision is now accepted and ready to land.Jul 26 2022, 4:35 AM
• karol updated this revision to Diff 14963.Jul 26 2022, 6:21 AM

remove duplicated variable

Harbormaster completed remote builds in B10885: Diff 14963.Jul 26 2022, 6:33 AM
• karol added a comment.Jul 28 2022, 6:08 AM
In D4631#133050, @tomek wrote:

We can consider extracting some common logic from this and D4581. We can e.g. create a function that determines number of threads and use it in both places.

Ok

• karol updated this revision to Diff 15055.Jul 28 2022, 6:11 AM

rebase

Harbormaster completed remote builds in B10945: Diff 15055.Jul 28 2022, 6:36 AM
Closed by commit rCOMMfcb69c145fde: [services] Tests - Backup - Initialize performance tests (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMfcb69c145fde: [services] Tests - Backup - Initialize performance tests.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
backup/
2 lines
51 lines

Diff 15192

View Options

services/commtest/tests/backup/backup_utils.rs

Loading...
View Options

services/commtest/tests/backup_performance_test.rs

Loading...