Page MenuHomePhabricator
Differential D4637

[services] Tests - Backup - Create new backup
ClosedPublic
Actions

Authored by • karol on Jul 26 2022, 2:50 AM.
Tags
None
Referenced Files
F2194912: D4637.id14930.diff
Fri, Jul 5, 8:36 AM
F2194553: D4637.id14930.diff
Fri, Jul 5, 5:41 AM
F2193499: D4637.id14967.diff
Thu, Jul 4, 10:20 PM
Unknown Object (File)
Wed, Jul 3, 11:30 PM
Unknown Object (File)
Wed, Jul 3, 3:37 AM
Unknown Object (File)
Wed, Jul 3, 3:08 AM
Unknown Object (File)
Mon, Jul 1, 3:56 AM
Unknown Object (File)
Wed, Jun 26, 7:13 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMM21ab868fa7bc: [services] Tests - Backup - Create new backup
Summary

Depends on D4631

Adding a piece of test for "add attachments for backup" functionality.

Test Plan
cd services
yarn run-performance-tests backup 1

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jul 26 2022, 2:50 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 26 2022, 2:50 AM
• karol added a child revision: D4632: [services] Tests - Backup - Add attachments for backups.Jul 26 2022, 2:53 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4631: [services] Tests - Backup - Initialize performance tests.
Harbormaster completed remote builds in B10867: Diff 14930.Jul 26 2022, 3:02 AM
• karol requested review of this revision.Jul 26 2022, 3:02 AM
tomek accepted this revision.Jul 26 2022, 5:14 AM
tomek added inline comments.
services/commtest/tests/backup_performance_test.rs
81 ↗(On Diff #14930)

Why do we need to explicitly drop? I think it is almost never a good idea.

This revision is now accepted and ready to land.Jul 26 2022, 5:14 AM
• karol added inline comments.Jul 26 2022, 6:57 AM
services/commtest/tests/backup_performance_test.rs
81 ↗(On Diff #14930)

Please, read my answer in https://phab.comm.dev/D4633#133164

• karol updated this revision to Diff 14967.Jul 26 2022, 7:02 AM
• karol edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B10889: Diff 14967.Jul 26 2022, 7:15 AM
• karol updated this revision to Diff 15056.Jul 28 2022, 6:12 AM

rebase

Harbormaster completed remote builds in B10946: Diff 15056.Jul 28 2022, 6:35 AM
Closed by commit rCOMM21ab868fa7bc: [services] Tests - Backup - Create new backup (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM21ab868fa7bc: [services] Tests - Backup - Create new backup.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
53 lines

Diff 15194

View Options

services/commtest/tests/backup_performance_test.rs

Loading...