Depends on D4652
Adding Logs to the backup service. Putting this up as a draft since I'm not 100% sure about this. Curious about your opinions.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looking at this diff, the idea from https://phab.comm.dev/D4652#inline-29573 sounds really beneficial.
| services/backup/src/DatabaseManager.cpp | ||
|---|---|---|
| 24 | Do you think we can safely log user id? @ashoat what do you think? | |
| services/backup/src/Reactors/server/CreateNewBackupReactor.cpp | ||
| 54 | Is logging this safe? Can it be used in some attacks? | |
| services/backup/src/Reactors/server/PullBackupReactor.cpp | ||
| 85–88 | Can we avoid this confusing notation and simply write values next to their descriptions (in all the places)? | |
| 119 | Not related to this diff, but are we still affected by this issue? | |
| services/backup/src/Reactors/server/SendLogReactor.cpp | ||
| 58 | Is writing this as an int really useful? | |
| 129–131 | We're computing the size twice. Can we avoid it? | |
| services/backup/src/DatabaseManager.cpp | ||
|---|---|---|
| 24 | Let's avoid that, see here https://phab.comm.dev/D4652#133661 | |
Comment Actions
I think this diff should be canceled because the Backup service going to Rust now. I can commandeer and close it if @tomek doesn't mind.