Add jest library to web to allow testing on web.
Details
Details
- Reviewers
tomek • abosh ashoat atul - Commits
- rCOMMb868710dbe73: [web] Add jest library to web
See that everyting still compiles.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Accepting this to preempt being added to the review :) (I review all external dependencies)
| web/package.json | ||
|---|---|---|
| 32 | Thanks for using the same version we used in other libraries! | |
Comment Actions
I added a Linear task to add web tests to CI
https://linear.app/comm/issue/ENG-1538/add-web-tests-to-ci
| web/babel.config.cjs | ||
|---|---|---|
| 17 ↗ | (On Diff #15209) | One thing to check here is if we really should use node as a target. Maybe we should instead use something browser-specific https://babeljs.io/docs/en/options#targets? It might be also the case that keeping node here is a good thing. So please check if after setting e.g. "targets": "> 0.25%, not dead" tests still work and running the web app is possible in both dev and prod modes. |
Comment Actions
Add browser target. Since we use ssr I figured the node target should
probably stay as well
| web/babel.config.cjs | ||
|---|---|---|
| 17 ↗ | (On Diff #15209) | My comment was a bit confusing. Having just the node is fine because this is a config for the test env. |