[Nix] Minimize arc's shebang length
ClosedPublic
Actions

Authored by • jon on Aug 2 2022, 11:15 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM63237fbb4ff6: [Nix] Minimize arc's shebang length

Summary

Fix darwin build of this package

Was about to send up another diff from the m1, and noticed that
master was failing to do nix develop after a rebase.

Test Plan

Install Nix

Then run, from any m1 or intel mac, on any branch:

nix develop github:commE2E/comm?ref=jonringer/unpatch-php-arc

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Aug 2 2022, 11:15 PM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptAug 2 2022, 11:15 PM

This closely following what the original nixpkgs package did https://github.com/NixOS/nixpkgs/blob/1830dc8874d29cc43e5f3a6120c2be71edaea666/pkgs/development/tools/misc/arcanist/default.nix#L16-L22

I decided to do the more "nix" thing, which turned out to be not be darwin compatible by 1 character.

• jon edited the test plan for this revision. (Show Details)Aug 2 2022, 11:24 PM

Harbormaster completed remote builds in B11076: Diff 15250.Aug 2 2022, 11:28 PM

• jon requested review of this revision.Aug 2 2022, 11:28 PM

ashoat accepted this revision.Aug 3 2022, 6:41 AM

This revision is now accepted and ready to land.Aug 3 2022, 6:41 AM

In D4727#135845, @jon wrote:

This closely following what the original nixpkgs package did https://github.com/NixOS/nixpkgs/blob/1830dc8874d29cc43e5f3a6120c2be71edaea666/pkgs/development/tools/misc/arcanist/default.nix#L16-L22

I decided to do the more "nix" thing, which turned out to be not be darwin compatible by 1 character.

This comment was extremely helpful for the review

Closed by commit rCOMM63237fbb4ff6: [Nix] Minimize arc's shebang length (authored by • jon). · Explain WhyAug 3 2022, 8:50 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM63237fbb4ff6: [Nix] Minimize arc's shebang length.

• jon mentioned this in D4489: [Services] Export shared services cpp as CMake Project.Aug 3 2022, 7:42 PM