Paths

Table of Contentst

[native] Double quote `BUILD_ARCH` in `build_openssl.sh`
ClosedPublic
Actions

Authored by • abosh on Aug 4 2022, 9:57 AM.

Tags

None

Referenced Files

	F3557342: D4737.diff
	Fri, Dec 27, 12:51 AM

	F3547856: D4737.id15325.diff
	Thu, Dec 26, 3:37 PM

	Unknown Object (File)
	Wed, Dec 25, 11:05 PM

	Unknown Object (File)
	Mon, Dec 16, 12:22 AM

	Unknown Object (File)
	Mon, Dec 16, 12:22 AM

	Unknown Object (File)
	Tue, Dec 3, 6:03 PM

	Unknown Object (File)
	Nov 2 2024, 5:29 PM

	Unknown Object (File)
	Oct 12 2024, 4:08 AM

View All Files

Subscribers

• adrian

ashoat

Details

Reviewers

atul
• jon
tomek

Commits

rCOMM64de81864af7: [native] Double quote `BUILD_ARCH` in `build_openssl.sh`

Summary

Quick double quote added that I missed in D4716.

Test Plan

ShellCheck.

Additionally, build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 4 2022, 9:57 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 4 2022, 9:57 AM

Harbormaster completed remote builds in B11125: Diff 15318.Aug 4 2022, 10:10 AM

• abosh requested review of this revision.Aug 4 2022, 10:10 AM

LGTM

This revision is now accepted and ready to land.Aug 4 2022, 10:11 AM

Closed by commit rCOMM64de81864af7: [native] Double quote `BUILD_ARCH` in `build_openssl.sh` (authored by • abosh). · Explain WhyAug 4 2022, 10:45 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM64de81864af7: [native] Double quote `BUILD_ARCH` in `build_openssl.sh`.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

bash/

build_openssl.sh

2 lines

Diff 15318

View Options

native/android/app/bash/build_openssl.sh

[native] Double quote `BUILD_ARCH` in `build_openssl.sh`ClosedPublicActions