[Android] Reference grpc utilities through CMake project
Changes PlannedPublicDraft
Actions

Authored by • jon on Aug 9 2022, 9:20 AM.

Tags

None

Referenced Files

	F3540339: D4778.id15486.diff
	Thu, Dec 26, 4:46 AM

	F3540338: D4778.id15482.diff
	Thu, Dec 26, 4:45 AM

	F3540337: D4778.id15478.diff
	Thu, Dec 26, 4:45 AM

	F3538596: D4778.id.diff
	Wed, Dec 25, 11:09 PM

	Unknown Object (File)
	Sun, Dec 15, 10:25 PM

	Unknown Object (File)
	Fri, Dec 13, 10:43 PM

	Unknown Object (File)
	Thu, Dec 12, 11:27 AM

	Unknown Object (File)
	Thu, Dec 12, 9:40 AM

Subscribers

Details

Reviewers

atul
• max
• karol

Summary

Use comm's grpc CMake project to ensure that the generated
files are automatically being built

Depends on D4774

Test Plan

Android CI passes

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/cmake-protobuf (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 9 2022, 9:20 AM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptAug 9 2022, 9:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 9:28 AM

Harbormaster failed remote builds in B11244: Diff 15478!

• jon mentioned this in D4774: [CMake] Generate protobuf headers as part of build.Aug 9 2022, 9:59 AM

Correct relative path to grpc directory

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 10:16 AM

Harbormaster failed remote builds in B11248: Diff 15482!

Avoid using already used "grpc" build directory

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 10:57 AM

Harbormaster failed remote builds in B11251: Diff 15486!

This is actually becoming quite a bit more complicated than I would have liked.. :(

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

6 lines

Diff 15486

View Options

native/android/app/CMakeLists.txt

[Android] Reference grpc utilities through CMake projectChanges PlannedPublicDraftActions