Page MenuHomePhabricator
Differential D4778

[Android] Reference grpc utilities through CMake project
Changes PlannedPublicDraft
Actions

Authored by • jon on Aug 9 2022, 9:20 AM.
Tags
None
Referenced Files
F3365751: D4778.diff
Mon, Nov 25, 7:34 AM
Unknown Object (File)
Sun, Nov 3, 7:46 PM
Unknown Object (File)
Sun, Nov 3, 7:46 PM
Unknown Object (File)
Sun, Nov 3, 7:46 PM
Unknown Object (File)
Sun, Nov 3, 7:44 PM
Unknown Object (File)
Sun, Nov 3, 7:26 PM
Unknown Object (File)
Oct 7 2024, 9:37 AM
Unknown Object (File)
Oct 7 2024, 9:37 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
tomek

Details

Reviewers
atul
• max
• karol
Summary

Use comm's grpc CMake project to ensure that the generated
files are automatically being built

Depends on D4774

Test Plan

Android CI passes

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/cmake-protobuf (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 9 2022, 9:20 AM
Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptAug 9 2022, 9:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 9:28 AM
Harbormaster failed remote builds in B11244: Diff 15478!
• jon mentioned this in D4774: [CMake] Generate protobuf headers as part of build.Aug 9 2022, 9:59 AM
• jon updated this revision to Diff 15482.Aug 9 2022, 10:06 AM

Correct relative path to grpc directory

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 10:16 AM
Harbormaster failed remote builds in B11248: Diff 15482!
• jon updated this revision to Diff 15486.Aug 9 2022, 10:47 AM

Avoid using already used "grpc" build directory

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 9 2022, 10:57 AM
Harbormaster failed remote builds in B11251: Diff 15486!
• jon added a comment.Aug 9 2022, 3:00 PM

This is actually becoming quite a bit more complicated than I would have liked.. :(

Revision Contents
Changeset List

PathSize
native/
android/
app/
6 lines

Diff 15486

View Options

native/android/app/CMakeLists.txt

Loading...